1376473 - nsHashPropertyBagBase::DeleteProperty does unnecessary hashtable lookups

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P3)

Comment 1

[Mats Palmgren (inactive)]

Attachment: Use Lookup instead of Get+Remove to avoid unnecessary hashtable lookups

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8881420 [details] [diff] [review]
Use Lookup instead of Get+Remove to avoid unnecessary hashtable lookups

Review of attachment 8881420 [details] [diff] [review]:
-----------------------------------------------------------------

Would be more straightforward with Remove() returning a bool, but OK.

::: xpcom/ds/nsHashPropertyBag.cpp
@@ -62,5 @@
>  nsHashPropertyBagBase::DeleteProperty(const nsAString& aName)
>  {
> -  // is it too much to ask for ns*Hashtable to return
> -  // a boolean indicating whether RemoveEntry succeeded
> -  // or not?!?!

See, making Remove return a boolean would be a good idea! :)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa2050ccc894
Use Lookup instead of Get+Remove to avoid unnecessary hashtable lookups.  r=froydnj

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aa2050ccc894