Closed
Bug 1376491
Opened 8 years ago
Closed 8 years ago
nsWindowDataSource::OnCloseWindow does unnecessary hashtable lookups
Categories
(Core :: General, enhancement, P3)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: perf)
Attachments
(1 file)
|
1.14 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
(This could be simpler if we had a nsInterfaceHashtable::Remove method.
I filed bug 1376498.)
Attachment #8881443 -
Flags: review?(nfroyd)
|
|
Assignee | |
Comment 2•8 years ago
|
||
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8881443 [details] [diff] [review]
Use Lookup instead of Get+Remove to avoid unnecessary hashtable lookups
Review of attachment 8881443 [details] [diff] [review]:
-----------------------------------------------------------------
Yes, nsInterfaceHashtable should have a very similar interface to nsRefPtrHashtable.
Attachment #8881443 -
Flags: review?(nfroyd) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5834c725da0
Use Lookup instead of Get+Remove to avoid unnecessary hashtable lookups. r=froydnj
|
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•