1376497 - Set mDocGroup for HTML docs being loaded via XHR

Status: NEW

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Henri Sivonen (:hsivonen)]

When loading an HTML doc via XHR, we sohuld set mDocGroup appropriately (before OnStartRequest fires to the HTML parser).

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1376497 - Put XHR docs in a DocGroup.

Review commit: https://reviewboard.mozilla.org/r/152596/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152596/

Comment 2

[Henri Sivonen (:hsivonen)]

Comment on attachment 8881461 [details]
Bug 1376497 - Put XHR docs in a DocGroup.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152596/diff/1-2/

Comment 3

[Henri Sivonen (:hsivonen)]

Comment on attachment 8881461 [details]
Bug 1376497 - Put XHR docs in a DocGroup.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152596/diff/2-3/

Comment 4

[Henri Sivonen (:hsivonen)]

Do we still care about this? (The bug was filed is the context of Quantum DOM.)

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Hmm, has the situation changed with the DOM Arena stuff. Do we already effectively do this?

Comment 6

[Sean Feng [:sefeng211]]

I don't think so?

Because DOM Arena helps if there is a node that is allocated/adopted this document before OnStartRequest, but I don't think that is always the case for XHR document?

Looks like XMLHttpRequestMainThread::OnDataAvailable would parse the XML and the create XML element, if this always get executed before OnStartRequest, then DOM Arena helps here.

Comment 7

[Andreas Farre [:farre] (PTO -> Dec 7th)]

There is a point in keeping DocGroups around if you're dispatching to/with them with a clear distinction that the work that is done is tied to that DocGroup, because then we want that work to show up in about:performance.