Add hard limit for cache slowness

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: valentin, Assigned: valentin)

Tracking

(Blocks: 1 bug)

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
For really old/bad hardware we might not have a significant delay from the local average, but CachePerfStats::IsCacheSlow() should still return true if the average is above a certain limit.

We want the limit to be preffable, and it's initial value would probably be based on telemetry: HTTP_SUB_OPEN_TO_FIRST_FROM_CACHE_V2 https://mzl.la/2tT7Gsb
(Assignee)

Comment 1

a year ago
Created attachment 8885716 [details] [diff] [review]
Add a preffable hard limit for cache slowness

MozReview-Commit-ID: 3GIbTq9L9MS
Attachment #8885716 - Flags: review?(michal.novotny)
(In reply to Valentin Gosu [:valentin] from comment #0)
> For really old/bad hardware we might not have a significant delay from the
> local average, but CachePerfStats::IsCacheSlow() should still return true if
> the average is above a certain limit.

The original idea was to have a hard limit for a delay at http://searchfox.org/mozilla-central/rev/31311070d9860b24fe4a7a36976c14b328c16208/netwerk/protocol/http/nsHttpChannel.cpp#9243

I don't think we really need to have a hard limit in IsCacheSlow, because even on a really slow HW, the delay hard limit will ensure that the racing will start in a reasonable time.
(Assignee)

Comment 3

a year ago
Comment on attachment 8885716 [details] [diff] [review]
Add a preffable hard limit for cache slowness

Oh, right, I misunderstood that.
I'll write up another patch.
Attachment #8885716 - Attachment is obsolete: true
Attachment #8885716 - Flags: review?(michal.novotny)
(Assignee)

Comment 4

a year ago
Created attachment 8885781 [details] [diff] [review]
Add a limit to how long we wait for the cache before we race

MozReview-Commit-ID: 59BLUjMeFFr
Attachment #8885781 - Flags: review?(michal.novotny)
Attachment #8885781 - Flags: review?(michal.novotny) → review+
(Assignee)

Comment 5

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fef3ce5bc6360bedb4548cc4c3396c7480f6406
Bug 1376503 - Add a limit to how long we wait for the cache before we race r=michal

Comment 6

a year ago
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fef3ce5bc63
Add a limit to how long we wait for the cache before we race r=michal

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0fef3ce5bc63
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.