Closed Bug 1376503 Opened 4 years ago Closed 4 years ago
Add hard limit for cache slowness
For really old/bad hardware we might not have a significant delay from the local average, but CachePerfStats::IsCacheSlow() should still return true if the average is above a certain limit. We want the limit to be preffable, and it's initial value would probably be based on telemetry: HTTP_SUB_OPEN_TO_FIRST_FROM_CACHE_V2 https://mzl.la/2tT7Gsb
(In reply to Valentin Gosu [:valentin] from comment #0) > For really old/bad hardware we might not have a significant delay from the > local average, but CachePerfStats::IsCacheSlow() should still return true if > the average is above a certain limit. The original idea was to have a hard limit for a delay at http://searchfox.org/mozilla-central/rev/31311070d9860b24fe4a7a36976c14b328c16208/netwerk/protocol/http/nsHttpChannel.cpp#9243 I don't think we really need to have a hard limit in IsCacheSlow, because even on a really slow HW, the delay hard limit will ensure that the racing will start in a reasonable time.
Comment on attachment 8885716 [details] [diff] [review] Add a preffable hard limit for cache slowness Oh, right, I misunderstood that. I'll write up another patch.
Attachment #8885781 - Flags: review?(michal.novotny)
Attachment #8885781 - Flags: review?(michal.novotny) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/0fef3ce5bc6360bedb4548cc4c3396c7480f6406 Bug 1376503 - Add a limit to how long we wait for the cache before we race r=michal
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/0fef3ce5bc63 Add a limit to how long we wait for the cache before we race r=michal
You need to log in before you can comment on or make changes to this bug.