Consolidate identical rules for win/linux/osx downloads indicator into the shared stylesheet

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Downloads Panel
P1
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: sfoster, Assigned: sfoster)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 56
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [photon-animation])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
The indicator.css stylesheet for each of windows / osx / linux has rules which are now identical and can be removed and shared from the indicator.inc.css

Updated

2 months ago
Flags: qe-verify?
Priority: -- → P2
Comment hidden (mozreview-request)

Updated

2 months ago
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Iteration: --- → 56.2 - Jul 10
Priority: P2 → P1
Comment hidden (mozreview-request)

Comment 3

2 months ago
mozreview-review
Comment on attachment 8881527 [details]
Bug 1376515 - Move shared download indicator rules to indicator.inc.css.

https://reviewboard.mozilla.org/r/152682/#review157972

Thanks!

::: browser/themes/linux/downloads/indicator.css:7
(Diff revision 2)
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  %include ../../shared/downloads/indicator.inc.css
>  
> -/*** Status and progress indicator ***/
>  

nit: newline at end of file, but no extra empty lines

::: browser/themes/shared/downloads/indicator.inc.css:20
(Diff revision 2)
> +#downloads-indicator-anchor {
> +  min-width: 16px;
> +  min-height: 16px;
> +}
> +
> +#downloads-button > #downloads-indicator-anchor > #downloads-indicator-icon {

Just #downloads-indicator-icon.
Attachment #8881527 - Flags: review?(paolo.mozmail) → review+
Comment hidden (mozreview-request)

Comment 5

2 months ago
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e421b9a0b337
Move shared download indicator rules to indicator.inc.css. r=Paolo

Comment 6

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e421b9a0b337
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Updated

2 months ago
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.