Closed Bug 1376590 Opened 3 years ago Closed 3 years ago
Manager::Create Top Level Compositor should initialize same process dependencies when falling back
GPUProcessManager::CreateTopLevelCompositor tries to create a remote compositor session with the GPU process, and if that fails, it will disable the GPU process and try to create an in process compositor session. The problem with this behaviour is that GPUProcessManager::EnsureCompositorManagerChild (and related) were called when still in the GPU process context. Once we call GPUProcessManager::DisableGPUProcess, we no longer have a valid CompositorManagerChild. We need to call this set of Ensure* functions again after disabling the GPU process. This is another root cause of mozilla::layers::CompositorBridgeParent::InitSameProcess crashes.
Attachment #8881578 - Flags: review?(dvander)
Attachment #8881578 - Flags: review?(dvander) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/8df38aa68781 When disabling the GPU process, ensure its dependencies are initialized for the same process. r=dvander
You need to log in before you can comment on or make changes to this bug.