1376628 - Static analysis fixes in dom/base/

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jan Keromnes [:janx]]

There are a few larges files in dom/base/ [0] that present opportunities for quick automated improvements using clang-tidy [1].

[0] For example:
- dom/base/nsContentUtils.cpp
- dom/base/nsDOMWindowUtils.cpp
- dom/base/nsGlobalWindow.cpp

[1] Using auto-fixable rules like:
- modernize-use-nullptr
- readability-else-after-return
- performance-for-range-copy

Comment 1

[Jan Keromnes [:janx]]

Attachment: Use nullptr where possible in dom/base/ (clang-tidy: modernize-use-nullptr).

Comment 2

[Jan Keromnes [:janx]]

Attachment: Don't use 'else' after 'break' or 'return' in dom/base/ (clang-tidy: readability-else-after-return).

Comment 3

[Jan Keromnes [:janx]]

Attachment: Change loop variable copies to const references where possible in dom/base/ (clang-tidy: performance-for-range-copy).

Comment 4

[Jan Keromnes [:janx]]

Attachment: Annotate methods with 'override' where possible in dom/base/ (clang-tidy: modernize-use-override).

Comment 5

[Jan Keromnes [:janx]]

Comment on attachment 8881619 [details] [diff] [review]
Annotate methods with 'override' where possible in dom/base/ (clang-tidy: modernize-use-override).

Review of attachment 8881619 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsContentUtils.cpp
@@ +538,5 @@
>    NS_DECL_NSIOBSERVER
>  
>    void Init();
>    void Shutdown();
> +  void AnnotateHang(HangMonitor::HangAnnotations& aAnnotations) override;

Note: This is a slightly unrelated drive-by fix ('virtual' is unnecessary because 'override' already implies it).

Comment 6

[Jan Keromnes [:janx]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4b92e2cc6f7

Comment 7

[Jan Keromnes [:janx]]

Comment on attachment 8881616 [details] [diff] [review]
Use nullptr where possible in dom/base/ (clang-tidy: modernize-use-nullptr).

Ehsan, please have a look when convenient.

Also, please indicate if any changes are not worth the effort / shouldn't be pursued.

Comment 8

[Jan Keromnes [:janx]]

Thank you Ehsan!

Sheriffs, please land these fixes.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/075df18a0a58
Use nullptr where possible in dom/base/ (clang-tidy: modernize-use-nullptr). r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7021a785963
Don't use 'else' after 'break' or 'return' in dom/base/ (clang-tidy: readability-else-after-return). r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab7c82c4c34c
Change loop variable copies to const references where possible in dom/base/ (clang-tidy: performance-for-range-copy). r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/7095cd0f91c7
Annotate methods with 'override' where possible in dom/base/ (clang-tidy: modernize-use-override). r=ehsan

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/075df18a0a58
https://hg.mozilla.org/mozilla-central/rev/b7021a785963
https://hg.mozilla.org/mozilla-central/rev/ab7c82c4c34c
https://hg.mozilla.org/mozilla-central/rev/7095cd0f91c7