1376640 - stylo: first-letter dynamic changes are still not quite right

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

Testcase:

    <!DOCTYPE html>
    <style>
      span.x { color: green; }
      div::first-letter { font-size: 100px; }
    </style>
    <div style="color: red">
      <span>C</span>
    </div>
    <script>
      onload = function() {
        setTimeout(function() {
          document.body.offsetWidth;
          document.querySelector("span").className = 'x'
        }, 500);
      };
    </script>
    
The problem is that the first-letter should be restyled from the <div> but we're restyling from the <span>.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix dynamic updates when an inline that sits between a first-letter and its block changes style

MozReview-Commit-ID: 8osMUpYVRvR

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2992d5af6251
Fix dynamic updates when an inline that sits between a first-letter and its block changes style.  r=heycam

Comment 3

[Carsten Book [:Tomcat]]

sorry Boris, had to back this out for causing assertion failures like https://treeherder.mozilla.org/logviewer.html#?job_id=110663297&repo=autoland

Comment 4

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa87c2519486
Backed out changeset 2992d5af6251 for assertion failures like  Assertion failure: mOwner == ExpectedOwnerForChild(aFrame) (Missed some frame in the hierarchy?)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Hmm.  This was green on try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5d1192b260e40053ab6c0f5c7cbbe606046595d

I guess that assert got added between then and now.  :(

Comment 6

[Boris Zbarsky [:bzbarsky]]

Ah, I expect the problem is that ExpectedOwnerForChild looks for the blockframe when aFrame is a first-letter frame, but the changes in this bug make us restyle the first-letter when restyling its parent (which might be an inline inside the blockframe).

Emilio, should that chunk of ExpectedOwnerForChild just get changed accordingly, or is there a reason it's looking for the block?

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Changing it to just look at the parent frame it's fine. The point of those assertions is to be aware of such changes to ensure nothing dumb starts happening. r=me on changing it to just return the parent frame.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf11951d30a6
Fix dynamic updates when an inline that sits between a first-letter and its block changes style.  r=heycam

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bf11951d30a6