Closed
Bug 1376643
Opened 8 years ago
Closed 8 years ago
Static analysis fixes in security/sandbox/
Categories
(Core :: Security: Process Sandboxing, enhancement)
Core
Security: Process Sandboxing
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: janx, Assigned: janx)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
2.71 KB,
patch
|
gcp
:
review+
|
Details | Diff | Splinter Review |
8.50 KB,
patch
|
gcp
:
review+
|
Details | Diff | Splinter Review |
There are several opportunities for small automated static analysis improvements in security/sandbox/.
Assignee | ||
Comment 1•8 years ago
|
||
Gian-Carlo, please have a look.
Attachment #8881628 -
Flags: review?(gpascutto)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8881629 -
Flags: review?(gpascutto)
Updated•8 years ago
|
Attachment #8881628 -
Flags: review?(gpascutto) → review+
Updated•8 years ago
|
Attachment #8881629 -
Flags: review?(gpascutto) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Assignee | ||
Comment 4•8 years ago
|
||
Try is green apart from some unrelated-looking oranges.
Sheriffs, please land these patches.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de8eb156e157
Use 'nullptr' where applicable in security/sandbox/. r=gcp
https://hg.mozilla.org/integration/mozilla-inbound/rev/f551e82578c1
Use 'override' and '= default' on applicable methods in security/sandbox/. r=gcp
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/de8eb156e157
https://hg.mozilla.org/mozilla-central/rev/f551e82578c1
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•