Static analysis fixes in security/sandbox/

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: janx, Assigned: janx)

Tracking

(Blocks 1 bug)

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments)

There are several opportunities for small automated static analysis improvements in security/sandbox/.
Gian-Carlo, please have a look.
Attachment #8881628 - Flags: review?(gpascutto)
Attachment #8881628 - Flags: review?(gpascutto) → review+
Attachment #8881629 - Flags: review?(gpascutto) → review+
Try is green apart from some unrelated-looking oranges.

Sheriffs, please land these patches.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de8eb156e157
Use 'nullptr' where applicable in security/sandbox/. r=gcp
https://hg.mozilla.org/integration/mozilla-inbound/rev/f551e82578c1
Use 'override' and '= default' on applicable methods in security/sandbox/. r=gcp
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/de8eb156e157
https://hg.mozilla.org/mozilla-central/rev/f551e82578c1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.