nsHTMLDocument::MatchNameAttribute() shows up in profiles due to the search on the name attribute

RESOLVED FIXED in Firefox 56

Status

()

defect
P2
normal
RESOLVED FIXED
2 years ago
a month ago

People

(Reporter: Ehsan, Assigned: jessica)

Tracking

(Blocks 1 bug)

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Reporter)

Description

2 years ago
See this Speedometer profile for example: http://bit.ly/2s0sgFB

The GetAttr() call (inlined) comes from MatchNameAttribute() here: <https://searchfox.org/mozilla-central/rev/fdb811340ac4e6b93703d72ee99217f3b1d250ac/dom/html/nsHTMLDocument.cpp#2059>

It would be nice to cache the index of the attribute using IndexOfAttr() and avoid repeatedly searching for the attribute.  This is an O(n) search per content appended/removed/etc notification.

I also looked into where this comes from.  This is quite sad, see for example this code in https://trac.webkit.org/export/216735/webkit/trunk/PerformanceTests/Speedometer/resources/todomvc/architecture-examples/emberjs/assets/vendor.js:

    // Support: IE<10
    // Check if getElementById returns elements by name
    // The broken getElementById methods don't pick up programatically-set names,
    // so use a roundabout getElementsByName test
    support.getById = assert(function( div ) {
        docElem.appendChild( div ).id = expando;
        return !document.getElementsByName || !document.getElementsByName( expando ).length;
    });

IINM this gets called when this This basically means any app including ember currently takes this perf hit in Gecko.

There is also similar code in jquery that causes a similar issue there as well.
(Reporter)

Comment 1

2 years ago
This code comes from the jquery sizzle library.  I filed an issue in the upstream library about this <https://github.com/jquery/sizzle/issues/402>, hopefully the entire getElementsByName() call can be removed (at least for non-IE browsers) at the library level.
Jessica, mind taking a look at this?
Flags: needinfo?(jjong)
Priority: -- → P2
(In reply to (Away 7/10-7/17) from comment #0)
> See this Speedometer profile for example: http://bit.ly/2s0sgFB
> 
> The GetAttr() call (inlined) comes from MatchNameAttribute() here:
> <https://searchfox.org/mozilla-central/rev/
> fdb811340ac4e6b93703d72ee99217f3b1d250ac/dom/html/nsHTMLDocument.cpp#2059>
> 
> It would be nice to cache the index of the attribute using IndexOfAttr() and
> avoid repeatedly searching for the attribute.  This is an O(n) search per
> content appended/removed/etc notification.

Do you mean to cache the 'name' attribute index? so that next time MatchNameAttribute() is called, we can get the 'name' attribute value directly using the cached index, right?
We may also need to reset the cached index when 'name' attribute is unset. It looks like we don't need to update the cached index when 'name' attribute value is changed.
Is there any other case where index of an attribute may change?
Flags: needinfo?(jjong) → needinfo?(ehsan)
(Reporter)

Comment 4

2 years ago
I've thought more about this after comment 0 but forgot to put the thoughts here before going on vacation, sorry about that!

The idea of caching the index of the name attribute may actually not be the best idea, that was the first thing that came to my mind.

The overall problem with the MatchNameAttribute callback IMO is that its callers can have some useful information that the callback can use but they don't have any way to pass this information down to the callback due to its generic nature.  For example:

  * The nsContentList::AttributeChanged() function receives the name of the changed attribute as an argument, so we tThe can immediately know whether a name attribute changed or not, and if not, we won't need to do any more work.  But right now this function just calls down into MatchNameAttribute and that function does the expensive search for the name attribute.

  * The rest of the nsContentList callbacks (ContentInserted, ContentAppended and ContentRemoved) could in theory quickly tell whether they need to look at a node or not if for example we could store a bit on the node indicating whether the node has a name attr on it.  This way we could avoid calling MatchNameAttribute() and doing the expensive search to find the name attr if we know in advance that the name attribute doesn't exist (which is the common case.)

This would mean that we can't use NS_GetFuncStringNodeList() to implement GetElementsByName() any more and we would need to implement a custom nsContentList class, but I think that should be relatively easy.

I think if we did the above, then we could avoid having to cache the index of the name attr, since the case where the node does have an attr should be quite rare and in the majority of the cases we can immediately tell inside the mutation observer callback that we don't have any work to do without having to scan the list of attributes.
Flags: needinfo?(ehsan)
Yeah, looking closer at the source of the problem, nsContentList implementation is kind of expensive if the matching function is sensitive to all attribute changes. Maybe nsContentList users should be able to pass in a list of attributes to listen to... but that's a bigger topic.

It looks like NS_GetFuncStringNodeList() and nsCacheableFuncStringNodeList (which inhertis from nsContentList) is only used by GetElementsByName(), can we change nsCacheableFuncStringNodeList directly into a custom nsContentList where we only act on changes on 'name' attribute and elements that have 'name' attribute, or should we do it in a new class inheriting nsCacheableFuncStringNodeList? Using a new class that inherits from nsCacheableFuncStringNodeList sounds more reasonable, right?
Flags: needinfo?(ehsan)
(Reporter)

Comment 6

2 years ago
(In reply to Jessica Jong [:jessica] from comment #5)
> Yeah, looking closer at the source of the problem, nsContentList
> implementation is kind of expensive if the matching function is sensitive to
> all attribute changes. Maybe nsContentList users should be able to pass in a
> list of attributes to listen to... but that's a bigger topic.

I haven't checked how many other consumers would need such a functionality.  If there are other consumers and they are performance sensitive perhaps designing something more generic is helpful but if we just manage to make getElementsByName() faster here without improving anything else I'd still be quite happy!  :-)

> It looks like NS_GetFuncStringNodeList() and nsCacheableFuncStringNodeList
> (which inhertis from nsContentList) is only used by GetElementsByName(), can
> we change nsCacheableFuncStringNodeList directly into a custom nsContentList
> where we only act on changes on 'name' attribute and elements that have
> 'name' attribute, or should we do it in a new class inheriting
> nsCacheableFuncStringNodeList? Using a new class that inherits from
> nsCacheableFuncStringNodeList sounds more reasonable, right?

Since after these changes nsCacheableFuncStringNodeList will no longer have a reason to exist, I'd say you can morph nsCacheableFuncStringNodeList into this new class (and please give it a better name, like nsElementsByNameContentList), and remove NS_GetFuncStringNodeList().  Or if you think it's cleaner, just create a new nsElementsByNameContentList class from scratch and remove both NS_GetFuncStringNodeList() and nsCacheableFuncStringNodeList.  nsCacheableFuncStringNodeList as it is currently doesn't really have any functionality that will be useful to you as far as I can tell so both approaches will probably result in the same outcome, it's up to you which one you prefer.  :-)

However, I think inheriting a new class from nsCacheableFuncStringNodeList is a slightly worse apporach since nsCacheableFuncStringNodeList really has nothing useful in it!
Flags: needinfo?(ehsan)
(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #6)
> Since after these changes nsCacheableFuncStringNodeList will no longer have
> a reason to exist, I'd say you can morph nsCacheableFuncStringNodeList into
> this new class (and please give it a better name, like
> nsElementsByNameContentList), and remove NS_GetFuncStringNodeList().  Or if
> you think it's cleaner, just create a new nsElementsByNameContentList class
> from scratch and remove both NS_GetFuncStringNodeList() and
> nsCacheableFuncStringNodeList.  nsCacheableFuncStringNodeList as it is
> currently doesn't really have any functionality that will be useful to you
> as far as I can tell so both approaches will probably result in the same
> outcome, it's up to you which one you prefer.  :-)
> 
> However, I think inheriting a new class from nsCacheableFuncStringNodeList
> is a slightly worse apporach since nsCacheableFuncStringNodeList really has
> nothing useful in it!

I see, I just though there'd be users in the future that need a more generic class like nsCacheableFuncStringNodeList, but we can remove it for now.
However, the new class, nsElementsByNameContentList still needs to inherit from nsCacheableFuncStringContentList,  right? since we still need to cache the list for a specific name.

I'll upload a patch soon, it will be easier to discuss if we have something first :)
Posted patch patch, v1. (obsolete) — Splinter Review
This is just a draft.

In this patch, I've changed 'nsCacheableFuncStringNodeList' into 'nsCachableElementsByNameNodeList' and it still inheris from nsCacheableFuncStringContentList. I didn't remove NS_GetFuncStringNodeList yet, since I'm not sure whether we should remove it or just rename it.

Ehsan, could you take a look if I'm in the right direction? Thanks!
Assignee: nobody → jjong
Attachment #8888226 - Flags: feedback?(ehsan)
(Reporter)

Comment 9

2 years ago
Comment on attachment 8888226 [details] [diff] [review]
patch, v1.

Review of attachment 8888226 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, yes, this looks like it's on the right track!

Note the subtree traversals can still be expensive.  It'd be nice to profile after these changes to see what the before and after picture looks like.  Thanks!

::: dom/base/nsContentList.cpp
@@ +340,3 @@
>  
>  already_AddRefed<nsContentList>
>  NS_GetFuncStringNodeList(nsINode* aRootNode,

I'd consider removing this helper also and just moving the call directly to https://searchfox.org/mozilla-central/rev/3a3af33f513071ea829debdfbc628caebcdf6996/dom/html/nsHTMLDocument.h#192.

@@ +1095,5 @@
> +  if (aAttribute != nsGkAtoms::name) {
> +    return;
> +  }
> +
> +  nsContentList::AttributeChanged(aDocument, aElement, aNameSpaceID, aAttribute,

Technically here and below your base class is nsCacheableFuncStringContentList not nsContentList, so you should use that class instead.

@@ +1106,5 @@
> +                                                  nsIContent* aFirstNewContent,
> +                                                  int32_t aNewIndexInContainer)
> +{
> +  bool anyContentHasName = false;
> +  for (nsIContent* cur = aFirstNewContent; cur; cur = cur->GetNextSibling()) {

I think you need to look into the entire subtree, not just the siblings, to also pick up the case where something gets appended with a kid somewhere which has a name attribute.  If this doesn't break any tests, please make sure to add a test that fails with your current patch!

@@ +1129,5 @@
> +                                                  int32_t aIndexInContainer)
> +{
> +  if (!aChild->HasName()) {
> +    return;
> +  }

I think here you should also look inside the entire subtree.

@@ +1144,5 @@
> +                                                 nsIContent* aPreviousSibling)
> +{
> +  if (!aChild->HasName()) {
> +    return;
> +  }

Ditto.
Attachment #8888226 - Flags: feedback?(ehsan) → feedback+
Posted patch patch, v2. (obsolete) — Splinter Review
In this patch, I addressed some of the feedback in comment 9:
- Removed NS_GetFuncStringHTMLCollection/NodeList and use GetFuncStringContentList directly
- Call base class function using nsCacheableFuncStringContentList instead of nsContentList
- For ContentAppended/Inserted/Removed, if we look into the entire subtree to see if any element has a name attribute, the worst case is that we end up searching the tree twice (the first time to look if there is any element with name attribute and the second time in nsContentUtils::MatchSelf to see if the name attribute matches the name passed). After thinking it again, I'd prefer to modify MatchNameAttribute to return early if the element doesn't have a name attribute. I think we can avoid possible performance regression this way.
- If we are going to use HasName() to check if an element has a name attribute, we need to set the flag for all elements, now we only set for elements that CanHaveName(), so fixed this part too.

TODO:
- add tests that pick up the case where something gets appended with a kid somewhere which has a name attribute
- see if we can notice any performance improvement by profiling
Attachment #8888226 - Attachment is obsolete: true
Posted patch patch, v3. (obsolete) — Splinter Review
- Added tests that pick up the case where something gets appended with a kid somewhere which has a name attribute
- Other details are in comment 10 and also in the commit message
- Profile running before (https://perfht.ml/2usUyvS) and after (https://perfht.ml/2usQko5) the patch. We can see that MatchNameAttribute is still called in ContentRemoved, but it does not do nsAttrAndChildArray::GetAttr() anymore, most likely because the matching element does not have a name attribute
Attachment #8888702 - Attachment is obsolete: true
Attachment #8889879 - Flags: review?(ehsan)
(Reporter)

Comment 12

2 years ago
(In reply to Jessica Jong [:jessica] from comment #11)
> - Profile running before (https://perfht.ml/2usUyvS) and after
> (https://perfht.ml/2usQko5) the patch. We can see that MatchNameAttribute is
> still called in ContentRemoved, but it does not do
> nsAttrAndChildArray::GetAttr() anymore, most likely because the matching
> element does not have a name attribute

This looks great!  It's a bit surprising to me how much MatchNameAttribute is showing up in the after profile still, but given that nsAttrAndChildArray::GetAttr() isn't showing up at all any more, it seems to me that every time that MatchNameAttribute() shows up, we're running a mutation observer and what you have showing up in the after profile is the pure overhead of running the mutation observer, and it's hard to see how to improve on that...
(Reporter)

Comment 13

2 years ago
Comment on attachment 8889879 [details] [diff] [review]
patch, v3.

Review of attachment 8889879 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsContentList.cpp
@@ +1080,5 @@
> +                                                   int32_t aModType,
> +                                                   const nsAttrValue* aOldValue)
> +{
> +  if (aAttribute != nsGkAtoms::name) {
> +    return;

Can you please add a comment explaining why returning early here is OK?

::: dom/html/nsGenericHTMLElement.cpp
@@ +486,5 @@
>    NS_ENSURE_SUCCESS(rv, rv);
>  
>    if (aDocument) {
>      RegAccessKey();
> +    if (CanHaveName(NodeInfo()->NameAtom()) && HasName()) {

It may be a good idea to break off the nsGenericHTMLElement.cpp part of this patch into a separate part because this part is allowing you to use the ElementHasName flag on all nodes, even those that CanHaveName() returns false for.  It took me a couple of minutes to understand how this is related to the patch, so I think having this as a separate part would make this a bit easier to understand.
Attachment #8889879 - Flags: review?(ehsan) → review+
Thanks Ehsan for the review.

(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #13)
> Comment on attachment 8889879 [details] [diff] [review]
> patch, v3.
> 
> Review of attachment 8889879 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/base/nsContentList.cpp
> @@ +1080,5 @@
> > +                                                   int32_t aModType,
> > +                                                   const nsAttrValue* aOldValue)
> > +{
> > +  if (aAttribute != nsGkAtoms::name) {
> > +    return;
> 
> Can you please add a comment explaining why returning early here is OK?

Sure, will add some comments here.

> 
> ::: dom/html/nsGenericHTMLElement.cpp
> @@ +486,5 @@
> >    NS_ENSURE_SUCCESS(rv, rv);
> >  
> >    if (aDocument) {
> >      RegAccessKey();
> > +    if (CanHaveName(NodeInfo()->NameAtom()) && HasName()) {
> 
> It may be a good idea to break off the nsGenericHTMLElement.cpp part of this
> patch into a separate part because this part is allowing you to use the
> ElementHasName flag on all nodes, even those that CanHaveName() returns
> false for.  It took me a couple of minutes to understand how this is related
> to the patch, so I think having this as a separate part would make this a
> bit easier to understand.

Ok, I'll separate this patch into two parts.
Splitting attachment 8889879 [details] [diff] [review] into two patches, carrying r+.
Attachment #8889879 - Attachment is obsolete: true
Attachment #8890266 - Flags: review+

Comment 18

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7eb9728ad2a1
Part 1: Let ElementHasName flag be applied to all nodes. r=ehsan
https://hg.mozilla.org/integration/mozilla-inbound/rev/753fd9590841
Part 2: Avoid rebuilding the list returned by getElementsByName when not needed. r=ehsan
Keywords: checkin-needed

Comment 19

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7eb9728ad2a1
https://hg.mozilla.org/mozilla-central/rev/753fd9590841
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
In BindToTree, is there a reason we check CanHaveName() before HasName()?

HasName() should be cheaper and would typically be false, I'd think.
Flags: needinfo?(jjong)
(In reply to Boris Zbarsky [:bz] from comment #20)
> In BindToTree, is there a reason we check CanHaveName() before HasName()?
> 
> HasName() should be cheaper and would typically be false, I'd think.

No special reason. I think we can do HasName() first, the same in RemoveFromNameTable(). I'll do it in a followup patch.
Flags: needinfo?(jjong)
Followup as suggested by bz.
Attachment #8891260 - Flags: review?(ehsan)
(Reporter)

Comment 23

2 years ago
Comment on attachment 8891260 [details] [diff] [review]
(followup) Check HasName() before CanHaveName().

Review of attachment 8891260 [details] [diff] [review]:
-----------------------------------------------------------------

(Please file follow-ups in the future, it's usually considered a bad idea to attach more patches to already fixed bugs since it makes the tracking of which parts landed when etc difficult.  In this case it doesn't matter much!)

Thanks!
Attachment #8891260 - Flags: review?(ehsan) → review+
(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #23)
> Comment on attachment 8891260 [details] [diff] [review]
> (followup) Check HasName() before CanHaveName().
> 
> Review of attachment 8891260 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> (Please file follow-ups in the future, it's usually considered a bad idea to
> attach more patches to already fixed bugs since it makes the tracking of
> which parts landed when etc difficult.  In this case it doesn't matter much!)
> 
> Thanks!

Noted, will file a separate bug in the future. Thanks.
checkin-needed for followup patch in attachment 8891260 [details] [diff] [review].
Keywords: checkin-needed

Comment 26

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd3e2939065e
Check HasName() before CanHaveName(). r=ehsan
Keywords: checkin-needed
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.