Closed Bug 1376832 Opened 7 years ago Closed 7 years ago

stylo: Return the up-to-date animation-only dirty bits after animation-only traversal for event handling

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1371450

People

(Reporter: boris, Unassigned)

References

(Blocks 1 open bug)

Details

In [1], we return needs_animation_only_restyle which is stored before calling traverse_subtree(). However, it seems it's better to return the up-to-date element.has_animation_only_dirty_descendants() to avoid doing redundant post traversal. [1] http://searchfox.org/mozilla-central/rev/fdb811340ac4e6b93703d72ee99217f3b1d250ac/servo/ports/geckolib/glue.rs#288
Not sure if this blocks Bug 1372642.
Yeah, currently the change does not have any performance impacts. The change is just it should be. In future if we skip setting the animation-only dirty bit if animations does not produce any change hints, it might be effective.
Blocks: stylo-css-animations
Summary: stylo: Return the up-to-date animation-only dirty bits after animation-only traversal → stylo: Return the up-to-date animation-only dirty bits after animation-only traversal for event handling
I did fix this in bug 1371450.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.