Use SystemGroup to label nsIThread::AsyncShutdown

RESOLVED FIXED in Firefox 57

Status

()

Core
XPCOM
RESOLVED FIXED
11 months ago
9 months ago

People

(Reporter: billm, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

This is a pretty simple method that's dispatched to the main thread in two places. In both cases we can label it with the SystemGroup.

http://searchfox.org/mozilla-central/search?q=nsIThread%3A%3AAsyncShutdown%22&case=false&regexp=false&path=
Maybe this bug could also cover labeling nsThreadShutdownAckEvent with the SystemGroup.
Comment hidden (mozreview-request)

Comment 3

9 months ago
First time submitting a patch to Mozilla.

Please take a look.

Sean
(Reporter)

Comment 4

9 months ago
mozreview-review
Comment on attachment 8901634 [details]
Bug 1376858 - Use SystemGroup to label nsIThread::AsyncShutdown,

https://reviewboard.mozilla.org/r/173040/#review179262
Attachment #8901634 - Flags: review?(wmccloskey) → review+
Thanks for the patch!

Comment 6

9 months ago
Pushed by wmccloskey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/778b209ee3d9
Use SystemGroup to label nsIThread::AsyncShutdown, r=billm
https://hg.mozilla.org/mozilla-central/rev/778b209ee3d9
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.