1376858 - Use SystemGroup to label nsIThread::AsyncShutdown

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

This is a pretty simple method that's dispatched to the main thread in two places. In both cases we can label it with the SystemGroup.

http://searchfox.org/mozilla-central/search?q=nsIThread%3A%3AAsyncShutdown%22&case=false&regexp=false&path=

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Maybe this bug could also cover labeling nsThreadShutdownAckEvent with the SystemGroup.

Comment 2

[seanvk]

Attachment: Bug 1376858 - Use SystemGroup to label nsIThread::AsyncShutdown,

Review commit: https://reviewboard.mozilla.org/r/173040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/173040/

Comment 3

[seanvk]

First time submitting a patch to Mozilla.

Please take a look.

Sean

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8901634 [details]
Bug 1376858 - Use SystemGroup to label nsIThread::AsyncShutdown,

https://reviewboard.mozilla.org/r/173040/#review179262

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Thanks for the patch!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/778b209ee3d9
Use SystemGroup to label nsIThread::AsyncShutdown, r=billm

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/778b209ee3d9