1376897 - stylo: self.owner_doc_matches_for_testing(shared_context.stylist.device()) assertion fails when styling a document in bfcache

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Brian Birtles (:birtles)]

Attachment: Test case

STR:
1. Load the attached test case in a debug Stylo build
2. Allow pop-ups
3. Re-load the test case

For me it hits the panic here:

  http://searchfox.org/mozilla-central/rev/fdb811340ac4e6b93703d72ee99217f3b1d250ac/servo/components/style/matching.rs#324

It seems like the owner doc of the element is the doc in the bfcache, but the doc of the pres context is the document associated with |w|.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: style: Move root font size handling outside of the cascade.

And merge it with the rest of the code handling root font-size changes.

Review commit: https://reviewboard.mozilla.org/r/155278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155278/

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: style: Avoid overriding the root font size from a getDefaultComputedStyle call.

Review commit: https://reviewboard.mozilla.org/r/155280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155280/

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1376897: Reftest.

Review commit: https://reviewboard.mozilla.org/r/155282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155282/

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Err, wrong bug...

Comment 5

[Emilio Cobos Álvarez [:emilio]]

This will be fixed by bug 1379505.

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Works for me on https://hg.mozilla.org/mozilla-central/log?rev=26516ba27081