Closed Bug 1376961 Opened 3 years ago Closed 3 years ago

Compartment checks do a slow TLS lookup

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
START_ASSERT_SAME_COMPARTMENT calls CurrentThreadIsHeapBusy which does an OOL call where we do a TLS lookup. Compartment checks are Nightly-only but this overhead makes it harder to profile.

Here's a patch to just inline CurrentThreadIsHeapBusy in START_ASSERT_SAME_COMPARTMENT.
Attachment #8881984 - Flags: review?(jcoppeard)
Attachment #8881984 - Flags: review?(jcoppeard) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e54513aa7922
Inline CurrentThreadIsHeapBusy in START_ASSERT_SAME_COMPARTMENT to avoid a TLS lookup for each compartment check. r=jonco
https://hg.mozilla.org/mozilla-central/rev/e54513aa7922
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.