1376974 - Get all wpt test types working with --try-test-paths try syntax

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Right now, regardless of which test paths are supplied, the wpt job attempts to run it with `--test-type testharness`

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

These try pushes show a fix (for Taskcluster tasks)
- normal wpt try push (all): https://treeherder.mozilla.org/#/jobs?repo=try&revision=e35efdde2276a456626f64c00400ec39cb654315
- webdriver dir (wdspec): https://treeherder.mozilla.org/#/jobs?repo=try&revision=3e130853949f61d270e4c0809d8cb29a1605d5de
- cookies dir (testharness): https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfb5b02479afdabfb097eab6c4e802f1454f50ef
- 2dcontext dir (reftest): https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f24084b7b7b782b4b628be38d2f93d2e97e4136

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Bug 1376974 - Get all wpt test types working with --try-test-paths try syntax;

Review commit: https://reviewboard.mozilla.org/r/153082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153082/

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8881999 [details]
Bug 1376974 - Get all wpt test types working with --try-test-paths try syntax;

https://reviewboard.mozilla.org/r/153082/#review158358

::: taskcluster/ci/test/tests.yml
(Diff revision 1)
>                  macosx.*:
>                      - web_platform_tests/prod_config.py
>                  default:
>                      - web_platform_tests/prod_config.py
>                      - remove_executables.py
> -        extra-options:

Isn't this going to mean that normal web-platform-tests jobs start running other test types as well as testharness tests? Don't we need something special for when there's try syntax?

Comment 4

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8881999 [details]
Bug 1376974 - Get all wpt test types working with --try-test-paths try syntax;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153082/diff/1-2/

Comment 5

[James Graham [:jgraham]]

Comment on attachment 8881999 [details]
Bug 1376974 - Get all wpt test types working with --try-test-paths try syntax;

https://reviewboard.mozilla.org/r/153082/#review158768

Comment 6

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8881999 [details]
Bug 1376974 - Get all wpt test types working with --try-test-paths try syntax;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153082/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1779b1ae7f5b
Get all wpt test types working with --try-test-paths try syntax; r=jgraham

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1779b1ae7f5b