Closed
Bug 1376985
Opened 7 years ago
Closed 7 years ago
Label DebuggerOnGCRunnable
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: billm, Assigned: billm)
References
Details
Attachments
(1 file)
|
1.48 KB,
patch
|
fitzgen
:
review+
|
Details | Diff | Splinter Review |
I'm guessing this hook runs chrome JS or something, so it seems safe to label it with the SystemGroup. If the hook runs content JS or touches any content DOM, then this patch is wrong, so please r- in that case :-). We have assertions to validate this stuff, but they're not perfectly reliable.
Attachment #8882009 -
Flags: review?(nfitzgerald)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8882009 [details] [diff] [review] patch Review of attachment 8882009 [details] [diff] [review]: ----------------------------------------------------------------- Your guess is correct :)
Attachment #8882009 -
Flags: review?(nfitzgerald) → review+
Pushed by wmccloskey@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c4c2e0bdd865 Label DebuggerOnGCRunnable (r=fitzgen)
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c4c2e0bdd865
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•