[Onboarding] The Activity Stream option menu is above the onboarding overlay

VERIFIED FIXED in Firefox 56

Status

()

enhancement
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: gasolin, Assigned: gasolin)

Tracking

unspecified
Firefox 57
Points:
---
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [photon-onboarding])

Attachments

(2 attachments)

Assignee

Description

2 years ago
When Activity Stream is enabled and the onboarding overlay is displayed, (when user click the fox icon),

When the user hover on the top right side, the user can still see the Activity Stream option menu.


It is caused by the Activity Stream option menu's z-index level is higher (12001) than the onboarding overlay's (999).
Assignee

Updated

2 years ago
Flags: qe-verify+
Priority: -- → P1
Whiteboard: [photon-onboarding]
Target Milestone: --- → Firefox 57
Comment hidden (mozreview-request)
Attachment #8882058 - Flags: review?(rexboy) → review+

Comment 3

2 years ago
mozreview-review
Comment on attachment 8882058 [details]
Bug 1377017 - [Onboarding] The Activity Stream option menu is above the onboarding overlay;

https://reviewboard.mozilla.org/r/153142/#review158366
Attachment #8882058 - Flags: review?(dtownsend) → review+
Comment on attachment 8882058 [details]
Bug 1377017 - [Onboarding] The Activity Stream option menu is above the onboarding overlay;

https://reviewboard.mozilla.org/r/153142/#review158370

This patch is fine.
We may need to at least let Activity Stream's people know (or know their prefer) about usage of z-index.
Assignee

Comment 5

2 years ago
Thanks for reminding, sent the note to the activity stream channel on slack https://mozilla.slack.com/messages/C4CGG9L9W/
Assignee

Updated

2 years ago
Assignee: nobody → gasolin
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 6

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0dfd83d33bfb
[Onboarding] The Activity Stream option menu is above the onboarding overlay;r=mossop,rexboy
Keywords: checkin-needed
QA Contact: jwilliams
Status: NEW → ASSIGNED

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0dfd83d33bfb
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
This issue has been verified on Win 10 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.