1377017 - [Onboarding] The Activity Stream option menu is above the onboarding overlay

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[[e-mail]]

When Activity Stream is enabled and the onboarding overlay is displayed, (when user click the fox icon),

When the user hover on the top right side, the user can still see the Activity Stream option menu.


It is caused by the Activity Stream option menu's z-index level is higher (12001) than the onboarding overlay's (999).

Comment 1

[[e-mail]]

Attachment: AS option menu over the onboarding overlay

Comment 2

[[e-mail]]

Attachment: Bug 1377017 - [Onboarding] The Activity Stream option menu is above the onboarding overlay;

Review commit: https://reviewboard.mozilla.org/r/153142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153142/

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8882058 [details]
Bug 1377017 - [Onboarding] The Activity Stream option menu is above the onboarding overlay;

https://reviewboard.mozilla.org/r/153142/#review158366

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8882058 [details]
Bug 1377017 - [Onboarding] The Activity Stream option menu is above the onboarding overlay;

https://reviewboard.mozilla.org/r/153142/#review158370

This patch is fine.
We may need to at least let Activity Stream's people know (or know their prefer) about usage of z-index.

Comment 5

[[e-mail]]

Thanks for reminding, sent the note to the activity stream channel on slack https://mozilla.slack.com/messages/C4CGG9L9W/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dfd83d33bfb
[Onboarding] The Activity Stream option menu is above the onboarding overlay;r=mossop,rexboy

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0dfd83d33bfb

Comment 8

[Justin [:JW_SoftvisionQA]]

This issue has been verified on Win 10 x64.