1377025 - Remove the use of mMutex from VideoFrameContainer::InvalidateWithFlags()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

See bug 1361622 comment 3. It is possible for SetCurrentFrames() to hold the lock for more than 1 sec. In order to prevent the main thread from being blocked by another thread in acquiring the lock, I will remove the use of mMutex from InvalidateWithFlags().

There are 3 members which will be accessed by multiple threads:
1. mImageSizeChanged
2. mIntrinsicSizeChanged
3. mIntrinsicSize

We need a way to synchronize the access without using mMutex.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1377025. P1 - dispatch image size changes to the main thread so mImageSizeChanged is for main thread only.

Review commit: https://reviewboard.mozilla.org/r/153232/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153232/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1377025. P2 - dispatch intrinsic size changes to the main thread.

So we can remove the use of mMutex from InvalidateWithFlags().

Review commit: https://reviewboard.mozilla.org/r/153234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153234/

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8882118 [details]
Bug 1377025. P1 - dispatch image size changes to the main thread so mImageSizeChanged is for main thread only.

https://reviewboard.mozilla.org/r/153232/#review158494

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8882119 [details]
Bug 1377025. P2 - dispatch intrinsic size changes to the main thread.

https://reviewboard.mozilla.org/r/153234/#review158496

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1b4b68e161a
P1 - dispatch image size changes to the main thread so mImageSizeChanged is for main thread only. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/1d14a426b9af
P2 - dispatch intrinsic size changes to the main thread. r=cpearce

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c1b4b68e161a
https://hg.mozilla.org/mozilla-central/rev/1d14a426b9af