PlacesUtils.getFolderContents should throw if a non-id is passed

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Currently it is possible to pass objects or other items to getFolderContents (as seen in bug 1119282). We should prevent this happening, as they typically get converted to '0' or '1' which are valid item ids.

Comment 2

2 years ago
mozreview-review
Comment on attachment 8882251 [details]
Bug 1377181 - PlacesUtils.getFolderContents should throw if a non-id is passed.

https://reviewboard.mozilla.org/r/153340/#review158586
Attachment #8882251 - Flags: review?(mak77) → review+

Comment 3

2 years ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ace8b8b02dc
PlacesUtils.getFolderContents should throw if a non-id is passed. r=mak

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9ace8b8b02dc
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.