Closed
Bug 1377181
Opened 7 years ago
Closed 7 years ago
PlacesUtils.getFolderContents should throw if a non-id is passed
Categories
(Toolkit :: Places, enhancement)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
Currently it is possible to pass objects or other items to getFolderContents (as seen in bug 1119282). We should prevent this happening, as they typically get converted to '0' or '1' which are valid item ids.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8882251 [details] Bug 1377181 - PlacesUtils.getFolderContents should throw if a non-id is passed. https://reviewboard.mozilla.org/r/153340/#review158586
Attachment #8882251 -
Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9ace8b8b02dc PlacesUtils.getFolderContents should throw if a non-id is passed. r=mak
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9ace8b8b02dc
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•