Session Restore button in tabstrip has janky animation

RESOLVED FIXED in Firefox 56

Status

()

Firefox
Session Restore
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: ewright, Assigned: ewright)

Tracking

unspecified
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

After turning on the pref in my own Nightly, I noticed that the animation is very jittery. As well, many times when clicked, the button animates small but does not fully disappear.
related to : https://bugzilla.mozilla.org/show_bug.cgi?id=1219725
Blocks: 1219725
Comment hidden (mozreview-request)
current patch changes: 
Button animates at same speed as new tabs open to appear smoother (100ms).
Padding removed from inner label so it smoothly goes to width of 0.
Setting the max-width of the sessionRestoreButton when it is first created, and removing the 'requestAnimationFrame', otherwise sometimes the listener will not catch the animation in time, resulting in not fully removing the button.

Comment 4

2 months ago
mozreview-review
Comment on attachment 8882271 [details]
Bug 1377182 - Fix animation for tabbar session restore button.

https://reviewboard.mozilla.org/r/153348/#review158770
Attachment #8882271 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Updated

2 months ago
Keywords: checkin-needed

Comment 5

2 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/993e3817d2fe
Fix animation for tabbar session restore button. r=Gijs
Keywords: checkin-needed

Comment 6

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/993e3817d2fe
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.