1377182 - Session Restore button in tabstrip has janky animation

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Erica Wright [:ewright]]

After turning on the pref in my own Nightly, I noticed that the animation is very jittery. As well, many times when clicked, the button animates small but does not fully disappear.

Comment 1

[Erica Wright [:ewright]]

related to : https://bugzilla.mozilla.org/show_bug.cgi?id=1219725

Comment 2

[Erica Wright [:ewright]]

Attachment: Bug 1377182 - Fix animation for tabbar session restore button.

Review commit: https://reviewboard.mozilla.org/r/153348/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153348/

Comment 3

[Erica Wright [:ewright]]

current patch changes: 
Button animates at same speed as new tabs open to appear smoother (100ms).
Padding removed from inner label so it smoothly goes to width of 0.
Setting the max-width of the sessionRestoreButton when it is first created, and removing the 'requestAnimationFrame', otherwise sometimes the listener will not catch the animation in time, resulting in not fully removing the button.

Comment 4

[:Gijs (he/him)]

Comment on attachment 8882271 [details]
Bug 1377182 - Fix animation for tabbar session restore button.

https://reviewboard.mozilla.org/r/153348/#review158770

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/993e3817d2fe
Fix animation for tabbar session restore button. r=Gijs

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/993e3817d2fe

Comment 7

[Sajedul Islam]

I have reproduced this bug with Nightly 56.0a1 (2017-06-29) on Windows 8.1 , 64 Bit ! 

This bug's fix is Verified with latest Beta 56.0b12 !

Build   ID    20170914024831
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0

[testday-20170915]