stylo: support inDOMUtils::GetAllStyleSheets()

RESOLVED FIXED in Firefox 56

Status

()

Core
CSS Parsing and Computation
P2
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

(Blocks: 1 bug)

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

File per bug 1290276 comment 41.

> * inDOMUtils::GetAllStyleSheets calls nsStyleSet::AppendAllXBLStyleSheets to get the XBL sheets that are used in the document.

https://dxr.mozilla.org/mozilla-central/rev/9af23c413a1f8d337b19b4f8450e241e91b71136/layout/inspector/inDOMUtils.cpp#113

Updated

8 months ago
Priority: -- → P2
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment on attachment 8882491 [details]
Bug 1377196 Part 1 - Store nsBindingManager* in ServoStyleSet.

https://reviewboard.mozilla.org/r/153544/#review158778
Attachment #8882491 - Flags: review?(cam) → review+
Comment on attachment 8882492 [details]
Bug 1377196 Part 2 - Add AppendAllXBLStyleSheets to ServoStyleSet.

https://reviewboard.mozilla.org/r/153546/#review158780

Looks good, thanks!

::: layout/style/StyleSetHandleInlines.h:212
(Diff revision 1)
> +  FORWARD_CONCRETE(AppendAllXBLStyleSheets, (aArray),
> +                                            (aArray));

This can just be FORWARD(AppendAllXBLStyleSheets, (aArray)) I think, since there's no difference in the arguments between Gecko and Servo.
Attachment #8882492 - Flags: review?(cam) → review+
(Assignee)

Comment 6

8 months ago
mozreview-review-reply
Comment on attachment 8882492 [details]
Bug 1377196 Part 2 - Add AppendAllXBLStyleSheets to ServoStyleSet.

https://reviewboard.mozilla.org/r/153546/#review158780

> This can just be FORWARD(AppendAllXBLStyleSheets, (aArray)) I think, since there's no difference in the arguments between Gecko and Servo.

Right. We can use `FORWARD(AppendAllXBLStyleSheets, (aArray));` here.
Comment hidden (mozreview-request)
Assignee: nobody → tlin
Status: NEW → ASSIGNED

Comment 8

8 months ago
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e955025554a6
Part 1 - Store nsBindingManager* in ServoStyleSet. r=heycam
https://hg.mozilla.org/integration/autoland/rev/f065e3a455a6
Part 2 - Add AppendAllXBLStyleSheets to ServoStyleSet. r=heycam

Comment 9

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e955025554a6
https://hg.mozilla.org/mozilla-central/rev/f065e3a455a6
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

Updated

8 months ago
Depends on: 1378300
You need to log in before you can comment on or make changes to this bug.