1377196 - stylo: support inDOMUtils::GetAllStyleSheets()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

File per bug 1290276 comment 41.

> * inDOMUtils::GetAllStyleSheets calls nsStyleSet::AppendAllXBLStyleSheets to get the XBL sheets that are used in the document.

https://dxr.mozilla.org/mozilla-central/rev/9af23c413a1f8d337b19b4f8450e241e91b71136/layout/inspector/inDOMUtils.cpp#113

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1377196 Part 1 - Store nsBindingManager* in ServoStyleSet.

We need to call nsBindingManager's method from ServoStyleSet in a later
patch.

Also, we call nsStyleSet::SetBindingManager() immediately after we call
nsStyleSet::Init(). Therefore, we could pass binding manager to Init()
directly, and delete SetBindingManager().

Review commit: https://reviewboard.mozilla.org/r/153544/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153544/

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1377196 Part 2 - Add AppendAllXBLStyleSheets to ServoStyleSet.

Review commit: https://reviewboard.mozilla.org/r/153546/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153546/

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=819eb5ef03058073254fe174f82d3e03e679a434

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 8882491 [details]
Bug 1377196 Part 1 - Store nsBindingManager* in ServoStyleSet.

https://reviewboard.mozilla.org/r/153544/#review158778

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8882492 [details]
Bug 1377196 Part 2 - Add AppendAllXBLStyleSheets to ServoStyleSet.

https://reviewboard.mozilla.org/r/153546/#review158780

Looks good, thanks!

::: layout/style/StyleSetHandleInlines.h:212
(Diff revision 1)
> +  FORWARD_CONCRETE(AppendAllXBLStyleSheets, (aArray),
> +                                            (aArray));

This can just be FORWARD(AppendAllXBLStyleSheets, (aArray)) I think, since there's no difference in the arguments between Gecko and Servo.

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8882492 [details]
Bug 1377196 Part 2 - Add AppendAllXBLStyleSheets to ServoStyleSet.

https://reviewboard.mozilla.org/r/153546/#review158780

> This can just be FORWARD(AppendAllXBLStyleSheets, (aArray)) I think, since there's no difference in the arguments between Gecko and Servo.

Right. We can use `FORWARD(AppendAllXBLStyleSheets, (aArray));` here.

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8882492 [details]
Bug 1377196 Part 2 - Add AppendAllXBLStyleSheets to ServoStyleSet.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153546/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e955025554a6
Part 1 - Store nsBindingManager* in ServoStyleSet. r=heycam
https://hg.mozilla.org/integration/autoland/rev/f065e3a455a6
Part 2 - Add AppendAllXBLStyleSheets to ServoStyleSet. r=heycam

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e955025554a6
https://hg.mozilla.org/mozilla-central/rev/f065e3a455a6