1377200 - Not syncing after profile refresh

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Edouard Oger [:eoger]]

STR:
1. Open Firefox with default profile
2. Connect that profile with Sync
3. Open about:support and "Refresh Nightly"
4. When Firefox opens again, try syncing -> nothing happens although the hamburger menu UI says we're still connected.

From sync logs:
> 1498760724393	Sync.Service	DEBUG	In sync: should login.
> 1498760724393	Sync.Status	DEBUG	Status.login: error.login.reason.no_username => error.login.reason.no_username
> 1498760724394	Sync.Status	DEBUG	Status.service: service.client_not_configured => service.client_not_configured

What happens is that the username pref is not set, so login() fails.
signedinuser.json does still exists with all of our login details.
What SHOULD happen, is browserid_identity.js setting that pref (by calling ensureLoggedIn BEFORE _checkSetup in Service#login), then we can continue in the happy flow.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Ed, IIRC you said you were working on this - shall we assign it to you?

Comment 2

[Edouard Oger [:eoger]]

Yep

Comment 3

[Edouard Oger [:eoger]]

Attachment: Bug 1377200 - Ensure Sync can recover after a profile refresh.

Review commit: https://reviewboard.mozilla.org/r/154268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/154268/

Comment 4

[Edouard Oger [:eoger]]

Tested on my Windows VM, it does unblock sync.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8883384 [details]
Bug 1377200 - Ensure Sync can recover after a profile refresh.

https://reviewboard.mozilla.org/r/154268/#review159394

Awesome, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d19b73f6ced
Ensure Sync can recover after a profile refresh. r=markh

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6d19b73f6ced

Comment 8

[Aravind Arul]

Operating system:Windows 10 X64
Firefox version:56.0a1

By testing this Bug in my latest Nightly version.After restarting nightly browser the Sync is already gets logged in and 
the Sync process is not happening.
The Bug is reproduced in latest nightly version.

[Bugday-20170705]