1377205 - Introduce DontThrottle class of service flag

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Honza Bambas (:mayhemer)]

For background loads that are perceivable like background audio.  The flag has to disable any throttling made on the download.

Comment 1

[Honza Bambas (:mayhemer)]

Just add the flag and check it's not set in nsHttpTransaction::EligibleForThrottling()

Comment 2

[Honza Bambas (:mayhemer)]

Attachment: v1

A very trivial patch.

Comment 3

[Honza Bambas (:mayhemer)]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61faef4994ac
Functionality to explicitly disallow throttle of HTTP responses. r=hurley

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/61faef4994ac

Comment 6

[Honza Bambas (:mayhemer)]

Comment on attachment 8892617 [details] [diff] [review]
v1

Approval Request Comment
[Feature/Bug causing the regression]: prerequisite for bug 1377206 which affects 56

see that bug approval message.

Comment 7

[Honza Bambas (:mayhemer)]

Comment on attachment 8892617 [details] [diff] [review]
v1

OK, I missed that the depending bug is still in review process and has not even landed on m-c.  I'll re-request when that is done.

Comment 8

[Honza Bambas (:mayhemer)]

Comment on attachment 8892617 [details] [diff] [review]
v1

This is a prerequisite for lading regression bug 1387090 on beta (56), nothing more.

Approval Request Comment
[Feature/Bug causing the regression]: not a regressions
[User impact if declined]: none
[Is this code covered by automated tests?]: no, this flag is unused
[Has the fix been verified in Nightly?]: n/a
[Needs manual test from QE? If yes, steps to reproduce]: n/a
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: does nothing
[String changes made/needed]: none

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8892617 [details] [diff] [review]
v1

This should land for beta 2, and must land before the patch in bug 1387090

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e648c321f8d3