Closed
Bug 1377205
Opened 7 years ago
Closed 7 years ago
Introduce DontThrottle class of service flag
Categories
(Core :: Networking: HTTP, defect, P1)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: mayhemer, Assigned: mayhemer)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
2.36 KB,
patch
|
u408661
:
review+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
For background loads that are perceivable like background audio. The flag has to disable any throttling made on the download.
Updated•7 years ago
|
Whiteboard: [necko-active]
Assignee | ||
Updated•7 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•7 years ago
|
||
Just add the flag and check it's not set in nsHttpTransaction::EligibleForThrottling()
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Attachment #8892617 -
Flags: review?(hurley) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/61faef4994ac Functionality to explicitly disallow throttle of HTTP responses. r=hurley
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/61faef4994ac
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8892617 [details] [diff] [review] v1 Approval Request Comment [Feature/Bug causing the regression]: prerequisite for bug 1377206 which affects 56 see that bug approval message.
Attachment #8892617 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 7•7 years ago
|
||
Comment on attachment 8892617 [details] [diff] [review] v1 OK, I missed that the depending bug is still in review process and has not even landed on m-c. I'll re-request when that is done.
Attachment #8892617 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 8•7 years ago
|
||
Comment on attachment 8892617 [details] [diff] [review] v1 This is a prerequisite for lading regression bug 1387090 on beta (56), nothing more. Approval Request Comment [Feature/Bug causing the regression]: not a regressions [User impact if declined]: none [Is this code covered by automated tests?]: no, this flag is unused [Has the fix been verified in Nightly?]: n/a [Needs manual test from QE? If yes, steps to reproduce]: n/a [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: does nothing [String changes made/needed]: none
Attachment #8892617 -
Flags: approval-mozilla-beta?
Comment 9•7 years ago
|
||
Comment on attachment 8892617 [details] [diff] [review] v1 This should land for beta 2, and must land before the patch in bug 1387090
Attachment #8892617 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 10•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/e648c321f8d3
status-firefox56:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•