Closed Bug 1377205 Opened 2 years ago Closed 2 years ago

Introduce DontThrottle class of service flag

Categories

(Core :: Networking: HTTP, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: mayhemer, Assigned: mayhemer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

For background loads that are perceivable like background audio.  The flag has to disable any throttling made on the download.
Blocks: 1377206
Whiteboard: [necko-active]
Priority: -- → P1
Just add the flag and check it's not set in nsHttpTransaction::EligibleForThrottling()
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Attached patch v1Splinter Review
A very trivial patch.
Attachment #8892617 - Flags: review?(hurley)
Attachment #8892617 - Flags: review?(hurley) → review+
Thanks!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61faef4994ac
Functionality to explicitly disallow throttle of HTTP responses. r=hurley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/61faef4994ac
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment on attachment 8892617 [details] [diff] [review]
v1

Approval Request Comment
[Feature/Bug causing the regression]: prerequisite for bug 1377206 which affects 56

see that bug approval message.
Attachment #8892617 - Flags: approval-mozilla-beta?
Comment on attachment 8892617 [details] [diff] [review]
v1

OK, I missed that the depending bug is still in review process and has not even landed on m-c.  I'll re-request when that is done.
Attachment #8892617 - Flags: approval-mozilla-beta?
Depends on: 1387090
Blocks: 1387090
No longer depends on: 1387090
Comment on attachment 8892617 [details] [diff] [review]
v1

This is a prerequisite for lading regression bug 1387090 on beta (56), nothing more.

Approval Request Comment
[Feature/Bug causing the regression]: not a regressions
[User impact if declined]: none
[Is this code covered by automated tests?]: no, this flag is unused
[Has the fix been verified in Nightly?]: n/a
[Needs manual test from QE? If yes, steps to reproduce]: n/a
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: does nothing
[String changes made/needed]: none
Attachment #8892617 - Flags: approval-mozilla-beta?
Comment on attachment 8892617 [details] [diff] [review]
v1

This should land for beta 2, and must land before the patch in bug 1387090
Attachment #8892617 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.