1377214 - Update mac builds to clang 4.0.1.

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, enhancement)

Description

[Ralph Giles (:rillian)]

On mac rust-bindgen, needed for stylo, needs libclang 4.0.1. Try just bumping all the mac builds to the latest stable release.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Bug 1377214 - Update macOS builders to clang 4.0.1.

This resolves an issue with stylo's bindgen.

Review commit: https://reviewboard.mozilla.org/r/153388/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153388/

Comment 2

[Ralph Giles (:rillian)]

Attachment: Bug 1377214 - build_clang: target macOS 10.9.

This is required to build clang 3.9.1 and later.

Review commit: https://reviewboard.mozilla.org/r/153390/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153390/

Comment 3

[Ralph Giles (:rillian)]

Attachment: Bug 1377214 - more informative error messages for build-clang.py failures;

Review commit: https://reviewboard.mozilla.org/r/153392/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153392/

Comment 4

[Ralph Giles (:rillian)]

Attachment: Bug 1377214 - Update mac and linux clang builds to 4.0.1.

Review commit: https://reviewboard.mozilla.org/r/153394/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153394/

Comment 5

[Ralph Giles (:rillian)]

The libclang 4.0.1 built from the try push with these patches exhibits bug 1368163. The homebrew build of llvm 4.0.0 or 4.0.1 doesn't, and copying libclang.dylib from the homebrew build into our build fixes the issue, so we can use our new skills for diffing giant mac libraries to try and figure out the difference.

In the meantime, delegating to homebrew's libclang on mac is looking more attractive. See Homebrew/homebrew-core#15133 for llvm 4.0.1.

Comment 6

[(no longer active)]

Comment on attachment 8882295 [details]
Bug 1377214 - more informative error messages for build-clang.py failures;

https://reviewboard.mozilla.org/r/153392/#review158688

Comment 7

[Ralph Giles (:rillian)]

Attachment: Bug 1377214 - Hardcode clang options for bindgen.

See if hard-coding the ci clang flags in the bindgen config
fixes the header issue on try.

Review commit: https://reviewboard.mozilla.org/r/153556/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153556/

Comment 8

[Ralph Giles (:rillian)]

Attachment: Bug 1377214 - Build stylo by default on nightly;

Review commit: https://reviewboard.mozilla.org/r/153558/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153558/

Comment 9

[Ralph Giles (:rillian)]

Comment on attachment 8882293 [details]
Bug 1377214 - Update macOS builders to clang 4.0.1.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153388/diff/1-2/

Comment 10

[Ralph Giles (:rillian)]

Comment on attachment 8882294 [details]
Bug 1377214 - build_clang: target macOS 10.9.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153390/diff/1-2/

Comment 11

[Ralph Giles (:rillian)]

Comment on attachment 8882295 [details]
Bug 1377214 - more informative error messages for build-clang.py failures;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153392/diff/1-2/

Comment 12

[Ralph Giles (:rillian)]

Comment on attachment 8882296 [details]
Bug 1377214 - Update mac and linux clang builds to 4.0.1.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153394/diff/1-2/

Comment 13

[Ralph Giles (:rillian)]

Comment on attachment 8882429 [details]
Bug 1377214 - Hardcode clang options for bindgen.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153556/diff/1-2/

Comment 14

[Ralph Giles (:rillian)]

Comment on attachment 8882430 [details]
Bug 1377214 - Build stylo by default on nightly;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153558/diff/1-2/

Comment 15

[Ralph Giles (:rillian)]

See also macports/macports-ports#542.

Comment 16

[Ralph Giles (:rillian)]

The macports update is now merged. It looks like we can wontfix this, unless we want to update automation builds to clang 4.0.1 in general.

Comment 17

[Ralph Giles (:rillian)]

Comment on attachment 8882430 [details]
Bug 1377214 - Build stylo by default on nightly;

https://reviewboard.mozilla.org/r/153558/#review165968

I believe this patch is out of date.

Comment 18

[Ralph Giles (:rillian)]

We now have toolchain tasks building linux64-clang-4 and clang-4. While the macosx builds (cross compiled from a linux host) are still using clang 3.9, the patches and original motivation for this bug are obsoleted by changes elsewhere. Closing.