1377228 - Crash in nsMsgSend when accessing empty body using nsIMsgSend.sendBody

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Kent James (:rkent)]

This crash primarily occurs in ExQuilla since that is the primary user of this interface.

nsMsgComposeAndSend::GetSendBody(nsAString& aBody) has:

return ConvertToUnicode(charSet.get(), m_attachment1_body, aBody);

m_attachment1_body though is initialized to 0 (null). Its value may come from nsMsgComposeAndSend::SnarfAndCopyBody:

  if (body.Length() > 0)
  {
    m_attachment1_body = ToNewCString(body);

That is, if the body is empty, m_attachment1_body stays null, and ConvertToUnicode crashes.

ExQuilla will implement a workaround for TB 52, but it would be good to fix in the core code. Yes this is mostly my problem.

Comment 1

[Wayne Mery (:wsmwk)]

You have a stack?

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1377228-crash-empty-string-encode.patch

I'm not sure why Kent didn't propose a patch since he can readily create the problem.

This is my suggestion, un-compiled and un-tested.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8882526 [details] [diff] [review]
1377228-crash-empty-string-encode.patch

Seems to compile ;-) Kent is the best to judge whether this is what he needs.

Comment 4

[Kent James (:rkent)]

Comment on attachment 8882526 [details] [diff] [review]
1377228-crash-empty-string-encode.patch

Review of attachment 8882526 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, I was not expecting you to fix this, but thanks!

Bug 1377809 is more of a problem for me, I'll probably try to fix that in JsAccount to minimize risk and ask that it be landed on a point release.

Comment 5

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/eb90850d4a8fda98a79d16acc6d7cb3087f0e812

Comment 6

[Jorg K (CEST = GMT+2)]

Beta (TB 55):
https://hg.mozilla.org/releases/comm-beta/rev/ec9b84935023

Comment 7

[Jorg K (CEST = GMT+2)]

TB 52 ESR:
https://hg.mozilla.org/releases/comm-esr52/rev/5e92983256746c3b8100444c2fb992efd239d1e7