1377262 - substitute_variables_slow functions generate huge amounts of code

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[(Away)]

https://pastebin.mozilla.org/9026066

In a recent stylo build there's a total of 908k in closures, almost all of which are of the form "style::properties::substitute_variables_XYZ_slow<closure>".

Simon, is there anything that can be done to reduce this?

Comment 1

[(Away)]

Oh, I misunderstood the function names. These functions aren't the closures themselves, they're actually functions substitute_variables_XYZ_slow<F>, which are instantiated with a closure for F.

Comment 2

[Simon Sapin (:SimonSapin)]

https://github.com/servo/servo/pull/17703 fixes this and more. It saves 1.6 to 2 megabytes, depending on what is measured.

Comment 3

[(Away)]

Amazing! I don't plan to measure all changes on Windows, but for this one I couldn't resist.

79479808 xul.dll
81366528 xul.dll.before

Assuming the PR lands as is, that's more than 1.8M saved on Win64. Go Simon!

Comment 4

[Simon Sapin (:SimonSapin)]

https://github.com/servo/servo/pull/17703 has landed in the servo repo but I can’t find it in https://hg.mozilla.org/integration/autoland . Is vcs-sync down?

Comment 5

[Bobby Holley (:bholley)]

(In reply to Simon Sapin (:SimonSapin) from comment #4)
> https://github.com/servo/servo/pull/17703 has landed in the servo repo but I
> can’t find it in https://hg.mozilla.org/integration/autoland . Is vcs-sync
> down?

autoland is currently closed due to the OSX symbols issue: https://treeherder.mozilla.org/#/jobs?repo=autoland

Comment 6

[(Away)]

https://hg.mozilla.org/integration/autoland/rev/c7f9f51b01bb49634982b3653431dedc30c14564

Comment 7

[(Away)]

https://hg.mozilla.org/mozilla-central/rev/c7f9f51b01bb49634982b3653431dedc30c14564