[a11y] Big blue buttons on all tabs must have a better focused state styling.

VERIFIED FIXED in Firefox 56

Status

()

Firefox
General
P3
normal
VERIFIED FIXED
2 months ago
14 days ago

People

(Reporter: yzen, Assigned: yzen)

Tracking

(Blocks: 1 bug, {access})

unspecified
Firefox 56
access
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [photon-onboarding])

Attachments

(5 attachments)

(Assignee)

Description

2 months ago
Right now only the text has a faintly dotted outline when the button is in focus. We should have something more pronounced, similar to the main Firefox UI, or about:preferences focused button layout.
(Assignee)

Updated

2 months ago
Blocks: 1377300

Comment 1

a month ago
according to the discussion with Photon onboarding PM/UX, change to P3
Priority: -- → P3
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
(Assignee)

Updated

a month ago
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
(Assignee)

Comment 2

24 days ago
Created attachment 8889548 [details] [diff] [review]
1377285 button focus styling.

Added button focus styling , it also works well in high contrast.
Attachment #8889548 - Flags: ui-review?(mverdi)
Attachment #8889548 - Flags: review?(dtownsend)
(Assignee)

Comment 3

24 days ago
Created attachment 8889549 [details]
Before
(Assignee)

Comment 4

24 days ago
Created attachment 8889550 [details]
Before High Contrast
(Assignee)

Comment 5

24 days ago
Created attachment 8889551 [details]
After
(Assignee)

Comment 6

24 days ago
Created attachment 8889553 [details]
After High Contrast

Comment 7

24 days ago
Comment on attachment 8889548 [details] [diff] [review]
1377285 button focus styling.

That's awesome - thank you!
Attachment #8889548 - Flags: ui-review?(mverdi) → ui-review+
Attachment #8889548 - Flags: review?(dtownsend) → review+
(Assignee)

Updated

23 days ago
Keywords: checkin-needed

Comment 8

23 days ago
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae7f1e8f2b35
better focus styling for onboarding-tour action buttons. r=mossop
Keywords: checkin-needed
(Assignee)

Updated

23 days ago
Blocks: 1377298

Comment 9

23 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ae7f1e8f2b35
Status: ASSIGNED → RESOLVED
Last Resolved: 23 days ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
I have reproduced this bug with nightly 56.0a1 (2017-06-29) on Linux Mint (64 Bit).

The bug's fix is now verified on Latest Nightly 56.0a1

Build ID 	20170803100352
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170802]
I can verify this issue has been fixed
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.