1377289 - [a11y] All images that are specific to each tab in the dialog should be accessible.

Status: VERIFIED FIXED

(Firefox :: General, defect, P3)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

If they are deemed essential they must have an alt text; if they are considered presentation only they must have role="presentation" (https://www.w3.org/TR/wai-aria/roles#presentation).

Comment 1

[Francis Lee [:frlee]]

according to the discussion with Photon onboarding PM/UX, change to P3

Comment 2

[[e-mail]]

The image is just for presentation and the meaningful description is at left side. So this would only need to add role="presentation" for each image

Comment 3

[[e-mail]]

Attachment: Bug 1377289 - [a11y] All tour images should be accessible;

Review commit: https://reviewboard.mozilla.org/r/157270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157270/

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8886478 [details]
Bug 1377289 - [a11y] All tour images should be accessible;

https://reviewboard.mozilla.org/r/157270/#review162732

::: browser/extensions/onboarding/README.md:30
(Diff revision 1)
>  
>  We would apply some rules:
>  
>  * All styles and ids should be formatted as `onboarding-*` to avoid conflict with the origin page.
>  * All strings in `locales` should be formatted as `onboarding.*` for consistency.
> +* For accessibility, images that are for presentation only should add `role="presentation"` attribute.

nit: add -> have

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8886478 [details]
Bug 1377289 - [a11y] All tour images should be accessible;

https://reviewboard.mozilla.org/r/157270/#review162966

Comment 6

[[e-mail]]

Comment on attachment 8886478 [details]
Bug 1377289 - [a11y] All tour images should be accessible;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157270/diff/1-2/

Comment 7

[[e-mail]]

Comment on attachment 8886478 [details]
Bug 1377289 - [a11y] All tour images should be accessible;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157270/diff/2-3/

Comment 8

[[e-mail]]

thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e89a6503c2f6
[a11y] All tour images should be accessible;r=mossop,yzen

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e89a6503c2f6

Comment 11

[Abe - QA (:Abe_LV)]

Hi Yura Zenevich,
Could you please provide the steps to verify this fix? Thanks

Comment 12

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Abe - QA (:Abe_LV) from comment #11)
> Hi Yura Zenevich,
> Could you please provide the steps to verify this fix? Thanks

Hi Abe,

You would essentially need a screen reader for that (like narator on windows or voice over on mac). What this patch does is that it hides the illustration image for all onboarding tour items from the screen readers.

Before the patch - screen reader is able to step into the image and the screen reader would announce "image" without any additional information.

With the patch - screen reader will skip the image entirely.

Comment 13

[Abe - QA (:Abe_LV)]

> Hi Abe,
> 
> You would essentially need a screen reader for that (like the narrator on windows
> or voice over on mac). What this patch does is that it hides the
> illustration image for all onboarding tour items from the screen readers.
> 
> Before the patch - screen reader is able to step into the image and the
> screen reader would announce "image" without any additional information.
> 
> With the patch - screen reader will skip the image entirely.

Thanks for this information.

I tested this accordingly and the screen reader skips the onboarding tour items.

Verified as fixed.

Comment 14

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8886478 [details]
Bug 1377289 - [a11y] All tour images should be accessible;

This is one of several bugs that make onboarding accessible to keyboard and screen reader users.
[Feature/Bug causing the regression]: None
[User impact if declined]: Users who use accessibility services or keyboard would not be able to use onboarding.
[Is this code covered by automated tests?]: No, HTML changes only
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: See comment 12
[List of other uplifts needed for the feature/fix]: not for this bug, but all onboarding accessibility bugs are listed in bug 1377300
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only affects users that use keyboard
[String changes made/needed]: None

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8886478 [details]
Bug 1377289 - [a11y] All tour images should be accessible;

Fixed in nightly 56 already before the merge. So we shouldn't need to uplift anything here.

Comment 16

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I can confirm Fx 56.0b8 respects the behavior mentioned in comment 14. I verified using Fx 56.0b8 on Windows 10 x64.

Comment 17

[Justin [:JW_SoftvisionQA]]

I have verified that this issue works as expected per comment 14 on Win 10 x64, Win 7 x86, Mac 10.13, & Ubuntu 16.04 x32 with Firefox 58.