Closed Bug 1377289 Opened 4 years ago Closed 4 years ago

[a11y] All images that are specific to each tab in the dialog should be accessible.

Categories

(Firefox :: General, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 56
Tracking Status
firefox56 --- verified
firefox58 --- verified

People

(Reporter: yzen, Assigned: gasolin)

References

Details

(Keywords: access, Whiteboard: [photon-onboarding])

Attachments

(1 file)

If they are deemed essential they must have an alt text; if they are considered presentation only they must have role="presentation" (https://www.w3.org/TR/wai-aria/roles#presentation).
according to the discussion with Photon onboarding PM/UX, change to P3
Priority: -- → P3
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
The image is just for presentation and the meaningful description is at left side. So this would only need to add role="presentation" for each image
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Priority: P3 → P1
Comment on attachment 8886478 [details]
Bug 1377289 - [a11y] All tour images should be accessible;

https://reviewboard.mozilla.org/r/157270/#review162732

::: browser/extensions/onboarding/README.md:30
(Diff revision 1)
>  
>  We would apply some rules:
>  
>  * All styles and ids should be formatted as `onboarding-*` to avoid conflict with the origin page.
>  * All strings in `locales` should be formatted as `onboarding.*` for consistency.
> +* For accessibility, images that are for presentation only should add `role="presentation"` attribute.

nit: add -> have
Attachment #8886478 - Flags: review?(yzenevich) → review+
Comment on attachment 8886478 [details]
Bug 1377289 - [a11y] All tour images should be accessible;

https://reviewboard.mozilla.org/r/157270/#review162966
Attachment #8886478 - Flags: review?(dtownsend) → review+
thanks!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e89a6503c2f6
[a11y] All tour images should be accessible;r=mossop,yzen
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e89a6503c2f6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Priority: P1 → P3
Hi Yura Zenevich,
Could you please provide the steps to verify this fix? Thanks
Flags: needinfo?(yzenevich)
(In reply to Abe - QA (:Abe_LV) from comment #11)
> Hi Yura Zenevich,
> Could you please provide the steps to verify this fix? Thanks

Hi Abe,

You would essentially need a screen reader for that (like narator on windows or voice over on mac). What this patch does is that it hides the illustration image for all onboarding tour items from the screen readers.

Before the patch - screen reader is able to step into the image and the screen reader would announce "image" without any additional information.

With the patch - screen reader will skip the image entirely.
Flags: needinfo?(yzenevich)
> Hi Abe,
> 
> You would essentially need a screen reader for that (like the narrator on windows
> or voice over on mac). What this patch does is that it hides the
> illustration image for all onboarding tour items from the screen readers.
> 
> Before the patch - screen reader is able to step into the image and the
> screen reader would announce "image" without any additional information.
> 
> With the patch - screen reader will skip the image entirely.

Thanks for this information.

I tested this accordingly and the screen reader skips the onboarding tour items.

Verified as fixed.
Status: RESOLVED → VERIFIED
Comment on attachment 8886478 [details]
Bug 1377289 - [a11y] All tour images should be accessible;

This is one of several bugs that make onboarding accessible to keyboard and screen reader users.
[Feature/Bug causing the regression]: None
[User impact if declined]: Users who use accessibility services or keyboard would not be able to use onboarding.
[Is this code covered by automated tests?]: No, HTML changes only
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: See comment 12
[List of other uplifts needed for the feature/fix]: not for this bug, but all onboarding accessibility bugs are listed in bug 1377300
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only affects users that use keyboard
[String changes made/needed]: None
Attachment #8886478 - Flags: approval-mozilla-beta?
Comment on attachment 8886478 [details]
Bug 1377289 - [a11y] All tour images should be accessible;

Fixed in nightly 56 already before the merge. So we shouldn't need to uplift anything here.
Attachment #8886478 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
I can confirm Fx 56.0b8 respects the behavior mentioned in comment 14. I verified using Fx 56.0b8 on Windows 10 x64.
Flags: qe-verify+
QA Contact: jwilliams
I have verified that this issue works as expected per comment 14 on Win 10 x64, Win 7 x86, Mac 10.13, & Ubuntu 16.04 x32 with Firefox 58.
You need to log in before you can comment on or make changes to this bug.