Closed Bug 1377320 Opened 4 years ago Closed 4 years ago

Hook up prompts for progressive web apps

Categories

(Firefox for Android Graveyard :: Web Apps (PWAs), enhancement)

53 Branch
All
Android
enhancement
Not set
normal

Tracking

(firefox56 fixed)

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: droeh, Assigned: droeh)

References

Details

Attachments

(1 file)

We need to support prompts in GV-based PWAs.
Attachment #8882411 - Flags: review?(nchen)
Blocks: 1285858
Comment on attachment 8882411 [details] [diff] [review]
pwa-prompts.patch

Review of attachment 8882411 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java
@@ +122,5 @@
> +        mPromptService.destroy();
> +        super.onDestroy();
> +    }
> +
> +    @Override 

Extra space
Attachment #8882411 - Flags: review?(nchen) → review+
https://hg.mozilla.org/mozilla-central/rev/6d86960c7c49
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Hi, could you give me an example of a prompt for testing this? Thanks!
QA Contact: oana.horvath
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.