Closed
Bug 1377320
Opened 7 years ago
Closed 7 years ago
Hook up prompts for progressive web apps
Categories
(Firefox for Android Graveyard :: Web Apps (PWAs), enhancement)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: droeh, Assigned: droeh)
References
Details
Attachments
(1 file)
|
3.87 KB,
patch
|
jchen
:
review+
|
Details | Diff | Splinter Review |
We need to support prompts in GV-based PWAs.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8882411 -
Flags: review?(nchen)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8882411 [details] [diff] [review]
pwa-prompts.patch
Review of attachment 8882411 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java
@@ +122,5 @@
> + mPromptService.destroy();
> + super.onDestroy();
> + }
> +
> + @Override
Extra space
Attachment #8882411 -
Flags: review?(nchen) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d86960c7c49
Add prompts support to PWAs. r=jchen
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
|
||
Comment 5•7 years ago
|
||
Hi, could you give me an example of a prompt for testing this? Thanks!
QA Contact: oana.horvath
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•