Profile: http://bit.ly/2tq8t6r from Jan: ehsan: isDate is just -- return toString.call(value) === '[object Date]' -- I wonder if we could optimize that better in Ion, will think about it
I'll check what kind of type information we have for |value|... When there's a single Class we could use TI to optimize (just need to be careful with @@toStringTag..). Worst case we could call a VM function and avoid some of the type checks at the start of obj_toString.
(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #2) > I don't see this in profiles any more: https://perfht.ml/2i74Rlx > > Could it be that something changed to fix it? Can we close the bug? No, I'm just incompetent at using the profiler UI: https://perfht.ml/2fLDbBL Sorry for the noise...
(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #3) > No, I'm just incompetent at using the profiler UI: https://perfht.ml/2fLDbBL > Sorry for the noise... Note that this profile is for Ember, not Angular, and the Ember case is bug 1384562. I should probably get back to that :)
status-firefox57: --- → wontfix
status-firefox58: --- → fix-optional
Priority: -- → P3
status-firefox58: fix-optional → wontfix
status-firefox59: --- → ?
You need to log in before you can comment on or make changes to this bug.