1377339 - obj_toString() called from isDate() in Angular could be faster

Status: RESOLVED WORKSFORME

(Core :: JavaScript Engine, enhancement, P3)

Description

[(no longer active)]

Profile: http://bit.ly/2tq8t6r

from Jan:

ehsan: isDate is just -- return toString.call(value) === '[object Date]' -- I wonder if we could optimize that better in Ion, will think about it

Comment 1

[Jan de Mooij [:jandem]]

I'll check what kind of type information we have for |value|...

When there's a single Class we could use TI to optimize (just need to be careful with @@toStringTag..). Worst case we could call a VM function and avoid some of the type checks at the start of obj_toString.

Comment 2

[(no longer active)]

I don't see this in profiles any more: https://perfht.ml/2i74Rlx

Could it be that something changed to fix it?  Can we close the bug?

Comment 3

[(no longer active)]

(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #2)
> I don't see this in profiles any more: https://perfht.ml/2i74Rlx
> 
> Could it be that something changed to fix it?  Can we close the bug?

No, I'm just incompetent at using the profiler UI: https://perfht.ml/2fLDbBL  Sorry for the noise...

Comment 4

[Jan de Mooij [:jandem]]

(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #3)
> No, I'm just incompetent at using the profiler UI: https://perfht.ml/2fLDbBL
> Sorry for the noise...

Note that this profile is for Ember, not Angular, and the Ember case is bug 1384562. I should probably get back to that :)

Comment 5

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals

Comment 6

[Ted Campbell [:tcampbell]]

I'm not seeing this behaviour any more.