1377357 - [geckoview] Build WebRTC files as part of AAR

Status: RESOLVED WORKSFORME

(GeckoView :: General, enhancement)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

They're currently commented out due to them using stuff that was only in Fennec, but I believe those issues are sorted out.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1377357 - Build WebRTC with the GeckoView AAR

Review commit: https://reviewboard.mozilla.org/r/153580/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153580/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8882458 [details]
Bug 1377357 - Build WebRTC with the GeckoView AAR

https://reviewboard.mozilla.org/r/153580/#review158868

I don't think this is quite correct: the WebRTC sources have moved forward.  See http://searchfox.org/mozilla-central/rev/17ebac68112bd635b458e831670c1e506ebc17ad/mobile/android/base/moz.build#331-333, which has:
```
    base_root = TOPSRCDIR + '/media/webrtc/trunk/webrtc/base/java/src/org/webrtc/'
    video_capture_root = TOPSRCDIR + '/media/webrtc/trunk/webrtc/modules/video_capture/android/java/src/org/webrtc/videoengine/'
    audio_root = TOPSRCDIR + '/media/webrtc/trunk/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/'
```
So there's no reference to `video_render` in `moz.build`.  Also, I think your first `srcDir` will not have the right packages in the IDE; you should drop the `org/webrtc` (and you should `exclude` if there are packages in there you _don't_ want).

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

This got fixed somewhere else.