[geckoview] Build WebRTC files as part of AAR

RESOLVED WORKSFORME

Status

()

Firefox for Android
GeckoView
RESOLVED WORKSFORME
6 months ago
3 months ago

People

(Reporter: snorp, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

They're currently commented out due to them using stuff that was only in Fennec, but I believe those issues are sorted out.
Comment hidden (mozreview-request)
Attachment #8882458 - Flags: review?(nchen) → review?(nalexander)
Comment on attachment 8882458 [details]
Bug 1377357 - Build WebRTC with the GeckoView AAR

https://reviewboard.mozilla.org/r/153580/#review158868

I don't think this is quite correct: the WebRTC sources have moved forward.  See http://searchfox.org/mozilla-central/rev/17ebac68112bd635b458e831670c1e506ebc17ad/mobile/android/base/moz.build#331-333, which has:
```
    base_root = TOPSRCDIR + '/media/webrtc/trunk/webrtc/base/java/src/org/webrtc/'
    video_capture_root = TOPSRCDIR + '/media/webrtc/trunk/webrtc/modules/video_capture/android/java/src/org/webrtc/videoengine/'
    audio_root = TOPSRCDIR + '/media/webrtc/trunk/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/'
```
So there's no reference to `video_render` in `moz.build`.  Also, I think your first `srcDir` will not have the right packages in the IDE; you should drop the `org/webrtc` (and you should `exclude` if there are packages in there you _don't_ want).
Attachment #8882458 - Flags: review?(nalexander) → review-
This got fixed somewhere else.
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.