Compiling on Linux gives "nsXPCOMStrings.h: No such file or directory" error

RESOLVED FIXED

Status

Instantbird
Other
--
major
RESOLVED FIXED
4 months ago
2 months ago

People

(Reporter: qheaden, Assigned: qheaden)

Tracking

(Blocks: 1 bug)

trunk
Unspecified
Linux

Details

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
When compiling Instantbird on Linux (I cannot be sure about the other platforms), the following error causes compilation to fail:

/comm-central/im/components/mintrayr/trayToolkit.h:21:28: fatal error: nsXPCOMStrings.h: No such file or directory
(Assignee)

Updated

4 months ago
Assignee: nobody → qheaden
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 months ago
Created attachment 8882490 [details] [diff] [review]
bug-1377373-v1.patch

This patch fixes the compilation issue by simply removing the nsXPCOMStrings.h include. There doesn't seem to be any ill effects from doing this and Instantbird builds and runs well.
Attachment #8882490 - Flags: review?(florian)
Attachment #8882490 - Flags: review?(clokep)
Comment on attachment 8882490 [details] [diff] [review]
bug-1377373-v1.patch

Review of attachment 8882490 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch! I haven't tried this myself, but comment 1 says you have :-).
Attachment #8882490 - Flags: review?(florian)
Attachment #8882490 - Flags: review?(clokep)
Attachment #8882490 - Flags: review+

Comment 3

3 months ago
Pushed by clokep@gmail.com:
https://hg.mozilla.org/comm-central/rev/3e3a3b2bdf47
Fix mintrayr compilation error message. r=florian
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Fixed in 56.
Blocks: 1383528
You need to log in before you can comment on or make changes to this bug.