Make nsWindow final to allow the compiler to devirtualize some calls

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

(Blocks 1 bug, {perf})

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [qf])

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
The nsChildWindow child class is empty so it can be removed
and thus we can make nsWindow 'final'.

Green on Linux.  I'm also working on the same for Windows, but
that doesn't quite work yet...
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ed958cccbc7f110e2fbb49c79f2b09d7b8d4b20d
Attachment #8882601 - Flags: review?(tnikkel)
Attachment #8882601 - Flags: review?(tnikkel) → review+
(Assignee)

Comment 2

2 years ago
Actually, I might as well tag along Android / UIKit here since they
were so trivial (assuming they compile):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=98a2b76d0a30bd7aad52fecc1fd7afc7470ed975
(Assignee)

Comment 3

2 years ago
(I'm fixing Windows in bug 1377490 and cocoa in bug 1377591)
(Assignee)

Comment 4

2 years ago
I'll fold this into the first part before landing.
Attachment #8882726 - Flags: review?(tnikkel)
Attachment #8882726 - Flags: review?(tnikkel) → review+

Comment 5

2 years ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b3a2348ce59f
Make nsWindow 'final' to possibly devirtualize some calls.  r=tn

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b3a2348ce59f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.