Closed
Bug 1377537
Opened 4 years ago
Closed 4 years ago
Move urlbar zoom icon styling into urlbar-searchbar.inc.css
Categories
(Firefox :: Theme, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: Gijs, Assigned: amosingh, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=css])
Attachments
(1 file)
|
2.23 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
The styling for the urlbar zoom button is currently here: https://dxr.mozilla.org/mozilla-central/rev/d9a144b7b6d994fc9a497c53b13f51a2a654d85e/browser/themes/shared/browser.inc.css#79-108 it should be moved to https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/urlbar-searchbar.inc.css instead.
|
||
Comment 1•4 years ago
|
||
Hello, can I work on this?
|
Reporter | |
Comment 2•4 years ago
|
||
(In reply to Vishal Kumar from comment #1) > Hello, can I work on this? Yep, feel free to submit a patch. Let me know if you have any questions.
|
Assignee | |
Comment 3•4 years ago
|
||
Hi, This is my first bug and I am submitting the patch. Please review and let me know any shortcomings. Regards, Amola
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8883909 -
Flags: review?(gijskruitbosch+bugs)
|
|
Reporter | |
Comment 4•4 years ago
|
||
Comment on attachment 8883909 [details] [diff] [review] Patch to move urlbar zoom icon css Review of attachment 8883909 [details] [diff] [review]: ----------------------------------------------------------------- Perfect, thanks!
Attachment #8883909 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Reporter | |
Updated•4 years ago
|
Assignee: nobody → singh.amola
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/650dc5fb7e7f Move urlbar zoom icon styling into urlbar-searchbar.inc.css, r=gijs
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/650dc5fb7e7f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in
before you can comment on or make changes to this bug.
Description
•