1377544 - Label runnables in ExtensionProtocolHandler

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Kershaw Chang [:kershaw]]

We still have some runnables that need to labeled in ExtensionProtocolHandler, such as [1], [2], and [3].

[1] http://searchfox.org/mozilla-central/rev/17ebac68112bd635b458e831670c1e506ebc17ad/netwerk/protocol/res/ExtensionProtocolHandler.cpp#240
[2] http://searchfox.org/mozilla-central/rev/17ebac68112bd635b458e831670c1e506ebc17ad/netwerk/protocol/res/ExtensionProtocolHandler.cpp#254
[3] http://searchfox.org/mozilla-central/rev/17ebac68112bd635b458e831670c1e506ebc17ad/netwerk/protocol/res/ExtensionProtocolHandler.cpp#292

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Label ExtensionProtocolHandler

Summary:
 - Remove AbstractThread according to bug 1372736
 - Let nsContentUtils::GetEventTargetByLoadInfo return nsISerialEventTarget
 - Label runnables in ExtensionStreamGetter

Thanks.

Comment 2

[Kershaw Chang [:kershaw]]

Attachment: Label ExtensionProtocolHandler, r=mayhemer

Rebase and carry r+.

Comment 3

[Kershaw Chang [:kershaw]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d884ca06c97c3753192776740a1195e20788838

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c61346d6f44
Labeling in ExtensionProtocolHandler, r=mayhemer

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1c61346d6f44

Comment 6

[Haik Aftandilian [:haik]]

I was under the impression that labeled runnables were only to be used in content. The nsIRunnables used in ExtensionProtocolHandler are only for the parent process and we shouldn't ever need them in content because the runnables are for opening files and content sandboxing prevents content processes from doing that.

For bug 1376496, I'm removing the nsILoadInfo that is sent from child to parent in the ExtensionProtocolHandler remoting. Could you recommend how to implement ExtensionStreamGetter::SetupEventTarget() without a loadinfo?

Comment 7

[Kershaw Chang [:kershaw]]

(In reply to Haik Aftandilian [:haik] from comment #6)
> I was under the impression that labeled runnables were only to be used in
> content. The nsIRunnables used in ExtensionProtocolHandler are only for the
> parent process and we shouldn't ever need them in content because the
> runnables are for opening files and content sandboxing prevents content
> processes from doing that.
> 

Yes, you are right. Labeled runnables are only used in content process.

But the abstract main thread used in ExtensionStreamGetter::GetAsync() is in content process. We need to also label it.
Also, when using nsIInputStreamPump in content process, we also have to assign a labeled event target to it.

> For bug 1376496, I'm removing the nsILoadInfo that is sent from child to
> parent in the ExtensionProtocolHandler remoting. Could you recommend how to
> implement ExtensionStreamGetter::SetupEventTarget() without a loadinfo?

It seems that the loadinfo is passed in ExtensionProtocolHandler::SubstituteRemoteFileChannel().
I think we can use nsContentUtils::GetEventTargetByLoadInfo() to get a labeled event target and try to pass it to ExtensionStreamGetter.