1377553 - Ensure that ASAN builds disable fstack-protector

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

From discussion: we should make sure we do not have stack-protector turned on in the ASAN builds.  

(We don't currently, but we would probably want to build our fuzzing and test targets with --enable-hardening once we add more compiler flags to it, and stackprotector is in --enable-hardening)

I don't remember why we need to do this though; or what the other compiler flag we wanted to turn off was.

Comment 1

[Christian Holler (:decoder)]

AFL disables fortify source by adding -U_FORTIFY_SOURCE in ASan builds and also doesn't add any stack-protector flags (which could also be for performance reasons, these flags don't help with anything that ASan doesn't already check).

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

I unstuck Bug 1418052.

To resolve this bug my intention is to make sure the ASAN builds set --disable-hardening

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Actually, it turns out you can't imply_option(--disable-hardening) so my new plan is to add a comment (as part of Bug 1418052) to the central place we add hardening flags.

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Marking this fixed with #1418052 done.