Closed Bug 1377553 Opened 3 years ago Closed 3 years ago

Ensure that ASAN builds disable fstack-protector

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: tjr, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor 21925])

From discussion: we should make sure we do not have stack-protector turned on in the ASAN builds.  

(We don't currently, but we would probably want to build our fuzzing and test targets with --enable-hardening once we add more compiler flags to it, and stackprotector is in --enable-hardening)

I don't remember why we need to do this though; or what the other compiler flag we wanted to turn off was.
AFL disables fortify source by adding -U_FORTIFY_SOURCE in ASan builds and also doesn't add any stack-protector flags (which could also be for performance reasons, these flags don't help with anything that ASan doesn't already check).
Flags: needinfo?(choller)
I unstuck Bug 1418052.

To resolve this bug my intention is to make sure the ASAN builds set --disable-hardening
Actually, it turns out you can't imply_option(--disable-hardening) so my new plan is to add a comment (as part of Bug 1418052) to the central place we add hardening flags.
Marking this fixed with #1418052 done.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Whiteboard: [tor 21925]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.