Closed
Bug 1377568
Opened 7 years ago
Closed 7 years ago
Show cache performance data in about:networking
Categories
(Core :: Networking: Cache, enhancement)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: michal, Assigned: michal)
References
(Blocks 1 open bug)
Details
(Whiteboard: [necko-active])
Attachments
(1 file, 4 obsolete files)
14.98 KB,
patch
|
michal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
The UI needs to be polished a bit. Valentin said he'll take care about this.
Flags: needinfo?(valentin.gosu)
Assignee | ||
Updated•7 years ago
|
Attachment #8883119 -
Attachment is obsolete: true
Updated•7 years ago
|
Flags: needinfo?(valentin.gosu)
Assignee | ||
Comment 4•7 years ago
|
||
:valentin - netwerk changes :ehsan - dom and toolkit changes
Attachment #8882691 -
Attachment is obsolete: true
Attachment #8883117 -
Attachment is obsolete: true
Attachment #8883331 -
Flags: review?(valentin.gosu)
Attachment #8883331 -
Flags: review?(ehsan)
Comment 5•7 years ago
|
||
Comment on attachment 8883331 [details] [diff] [review] patch v2 - merged with valentin's UI changes Review of attachment 8883331 [details] [diff] [review]: ----------------------------------------------------------------- r=me on the DOM and toolkit parts. ::: dom/webidl/NetDashboard.webidl @@ +75,5 @@ > dictionary ConnStatusDict { > DOMString status = ""; > }; > > +dictionary RcwnPerfStats { It seems like this file only defines some dictionaries in order to utilize the WebIDL codegen for them, which is fine, but it would be nice to document this in the beginning of this WebIDL file. ::: toolkit/content/aboutNetworking.js @@ +142,5 @@ > document.getElementById("rcwn_cache_net_count").innerText = netWon; > + document.getElementById("rcwn_cache_slow").innerText = cacheSlow; > + document.getElementById("rcwn_cache_not_slow").innerText = cacheNotSlow; > + > + // Keep in sync with CachePerfStats::EDataType in CacheFileUtils.h Please add the mirrored comment to <https://searchfox.org/mozilla-central/rev/a3a739de04ee6134c11546568a33dbb6a6a29907/netwerk/cache2/CacheFileUtils.h#153>.
Attachment #8883331 -
Flags: review?(ehsan) → review+
Updated•7 years ago
|
Attachment #8883331 -
Flags: review?(valentin.gosu) → review+
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8883331 -
Attachment is obsolete: true
Attachment #8883502 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/655965b07027 Show cache performance data in about:networking, r=valentin, r=ehsan
Keywords: checkin-needed
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/655965b07027
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•