Show cache performance data in about:networking

RESOLVED FIXED in Firefox 56

Status

()

Core
Networking: Cache
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: michal, Assigned: michal)

Tracking

(Blocks: 1 bug)

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment, 4 obsolete attachments)

Comment hidden (empty)
(Assignee)

Comment 1

4 months ago
Created attachment 8882691 [details] [diff] [review]
patch

The UI needs to be polished a bit. Valentin said he'll take care about this.
Flags: needinfo?(valentin.gosu)
Created attachment 8883117 [details] [diff] [review]
Clean up the RCWN Cache performance stats UI

MozReview-Commit-ID: DGVcCHndEPP
Created attachment 8883119 [details] [diff] [review]
Make about:networking keep the current section when refreshing

MozReview-Commit-ID: CkKeFnQiP66
(Assignee)

Updated

4 months ago
Attachment #8883119 - Attachment is obsolete: true
Flags: needinfo?(valentin.gosu)
(Assignee)

Comment 4

4 months ago
Created attachment 8883331 [details] [diff] [review]
patch v2 - merged with valentin's UI changes

:valentin - netwerk changes
:ehsan - dom and toolkit changes
Attachment #8882691 - Attachment is obsolete: true
Attachment #8883117 - Attachment is obsolete: true
Attachment #8883331 - Flags: review?(valentin.gosu)
Attachment #8883331 - Flags: review?(ehsan)

Comment 5

4 months ago
Comment on attachment 8883331 [details] [diff] [review]
patch v2 - merged with valentin's UI changes

Review of attachment 8883331 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the DOM and toolkit parts.

::: dom/webidl/NetDashboard.webidl
@@ +75,5 @@
>  dictionary ConnStatusDict {
>    DOMString status = "";
>  };
>  
> +dictionary RcwnPerfStats {

It seems like this file only defines some dictionaries in order to utilize the WebIDL codegen for them, which is fine, but it would be nice to document this in the beginning of this WebIDL file.

::: toolkit/content/aboutNetworking.js
@@ +142,5 @@
>    document.getElementById("rcwn_cache_net_count").innerText = netWon;
> +  document.getElementById("rcwn_cache_slow").innerText = cacheSlow;
> +  document.getElementById("rcwn_cache_not_slow").innerText = cacheNotSlow;
> +
> +  // Keep in sync with CachePerfStats::EDataType in CacheFileUtils.h

Please add the mirrored comment to <https://searchfox.org/mozilla-central/rev/a3a739de04ee6134c11546568a33dbb6a6a29907/netwerk/cache2/CacheFileUtils.h#153>.
Attachment #8883331 - Flags: review?(ehsan) → review+
Attachment #8883331 - Flags: review?(valentin.gosu) → review+
(Assignee)

Comment 6

4 months ago
Created attachment 8883502 [details] [diff] [review]
patch v3 - added comments
Attachment #8883331 - Attachment is obsolete: true
Attachment #8883502 - Flags: review+
(Assignee)

Updated

4 months ago
Keywords: checkin-needed

Comment 7

4 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/655965b07027
Show cache performance data in about:networking, r=valentin, r=ehsan
Keywords: checkin-needed

Comment 8

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/655965b07027
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.