1377568 - Show cache performance data in about:networking

Status: RESOLVED FIXED

(Core :: Networking: Cache, enhancement)

Comment 1

[Michal Novotny [:michal]]

Attachment: patch

The UI needs to be polished a bit. Valentin said he'll take care about this.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Clean up the RCWN Cache performance stats UI

MozReview-Commit-ID: DGVcCHndEPP

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Make about:networking keep the current section when refreshing

MozReview-Commit-ID: CkKeFnQiP66

Comment 4

[Michal Novotny [:michal]]

Attachment: patch v2 - merged with valentin's UI changes

:valentin - netwerk changes
:ehsan - dom and toolkit changes

Comment 5

[(no longer active)]

Comment on attachment 8883331 [details] [diff] [review]
patch v2 - merged with valentin's UI changes

Review of attachment 8883331 [details] [diff] [review]:
-----------------------------------------------------------------

r=me on the DOM and toolkit parts.

::: dom/webidl/NetDashboard.webidl
@@ +75,5 @@
>  dictionary ConnStatusDict {
>    DOMString status = "";
>  };
>  
> +dictionary RcwnPerfStats {

It seems like this file only defines some dictionaries in order to utilize the WebIDL codegen for them, which is fine, but it would be nice to document this in the beginning of this WebIDL file.

::: toolkit/content/aboutNetworking.js
@@ +142,5 @@
>    document.getElementById("rcwn_cache_net_count").innerText = netWon;
> +  document.getElementById("rcwn_cache_slow").innerText = cacheSlow;
> +  document.getElementById("rcwn_cache_not_slow").innerText = cacheNotSlow;
> +
> +  // Keep in sync with CachePerfStats::EDataType in CacheFileUtils.h

Please add the mirrored comment to <https://searchfox.org/mozilla-central/rev/a3a739de04ee6134c11546568a33dbb6a6a29907/netwerk/cache2/CacheFileUtils.h#153>.

Comment 6

[Michal Novotny [:michal]]

Attachment: patch v3 - added comments

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/655965b07027
Show cache performance data in about:networking, r=valentin, r=ehsan

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/655965b07027