1377570 - Enable RCWN on mobile

Status: RESOLVED FIXED

(Core :: Networking: Cache, enhancement, P2)

Description

[Michal Novotny [:michal]]

RCWN is disabled on mobile now. We need to verify that we can rely on information provided by nsINetworkLinkService::linkType when deciding whether we're on metered network or not. This bug isn't blocking for RCWN in release 57.

Comment 1

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 2

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 3

[Jason Duell]

We're pushing mobile this year.  So let's make sure we get RCWN turned on when a phone is on wifi

Comment 4

[Damian Yerrick]

Even if the Wi-Fi's uplink is metered, as in the case of Wi-Fi with a satellite or cellular uplink? (Satellite loses the race easily, but fixed cellular might win.) Or do we trust the OS to tell Firefox whether a particular Wi-Fi network's uplink is metered?

Comment 5

[Michal Novotny [:michal]]

Attachment: patch

Comment 6

[Michal Novotny [:michal]]

(In reply to Damian Yerrick from comment #4)
> Even if the Wi-Fi's uplink is metered, as in the case of Wi-Fi with a
> satellite or cellular uplink? (Satellite loses the race easily, but fixed
> cellular might win.) Or do we trust the OS to tell Firefox whether a
> particular Wi-Fi network's uplink is metered?

We cannot detect such setup. Racing is disabled when the phone uses cellular data, otherwise it's enabled.

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8980220 [details] [diff] [review]
patch

Review of attachment 8980220 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutNetworking.js
@@ +135,5 @@
> +        linkType == Ci.nsINetworkLinkService.LINK_TYPE_USB ||
> +        linkType == Ci.nsINetworkLinkService.LINK_TYPE_WIFI)) {
> +    status = false;
> +  }
> + 

nit: trailing whitespace

@@ +143,5 @@
>    let cacheSlow = data.cacheSlowCount;
>    let cacheNotSlow = data.cacheNotSlowCount;
>  
> +
> +

nit: whitespace

Comment 8

[Michal Novotny [:michal]]

Attachment: patch v2 - removed white spaces

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4408bb821f5b
Enable RCWN on mobile. r=valentin

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4408bb821f5b

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Is that something we want to add to the release notes?

Comment 12

[Michal Novotny [:michal]]

Maybe we could. Release notes for 59 mentioned this feature, so we can now say that this is now also enabled on mobile when using wifi.

Comment 14

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Is there something we should be doing to verify this?
And, can you suggest wording for a release note for 62?

Comment 15

[Michal Novotny [:michal]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #14)
> Is there something we should be doing to verify this?

You can verify that detecting WiFi works by looking at about:networking#rcwn where RCWN status should be true only when WiFi is used.

> And, can you suggest wording for a release note for 62?

Faster page load times on mobile when using WiFi by loading resources from the network if the disk cache is too slow.

Comment 16

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added to Firefox 62 release notes.