Closed Bug 1377570 Opened 3 years ago Closed 2 years ago

Enable RCWN on mobile

Categories

(Core :: Networking: Cache, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
relnote-firefox --- 62+
firefox62 --- fixed

People

(Reporter: michal, Assigned: michal)

References

(Depends on 2 open bugs, Blocks 1 open bug)

Details

(Whiteboard: [necko-backlog])

Attachments

(1 file, 1 obsolete file)

RCWN is disabled on mobile now. We need to verify that we can rely on information provided by nsINetworkLinkService::linkType when deciding whether we're on metered network or not. This bug isn't blocking for RCWN in release 57.
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P1
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: P1 → P3
We're pushing mobile this year.  So let's make sure we get RCWN turned on when a phone is on wifi
Priority: P3 → P2
Even if the Wi-Fi's uplink is metered, as in the case of Wi-Fi with a satellite or cellular uplink? (Satellite loses the race easily, but fixed cellular might win.) Or do we trust the OS to tell Firefox whether a particular Wi-Fi network's uplink is metered?
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → michal.novotny
Attachment #8980220 - Flags: review?(valentin.gosu)
(In reply to Damian Yerrick from comment #4)
> Even if the Wi-Fi's uplink is metered, as in the case of Wi-Fi with a
> satellite or cellular uplink? (Satellite loses the race easily, but fixed
> cellular might win.) Or do we trust the OS to tell Firefox whether a
> particular Wi-Fi network's uplink is metered?

We cannot detect such setup. Racing is disabled when the phone uses cellular data, otherwise it's enabled.
Comment on attachment 8980220 [details] [diff] [review]
patch

Review of attachment 8980220 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutNetworking.js
@@ +135,5 @@
> +        linkType == Ci.nsINetworkLinkService.LINK_TYPE_USB ||
> +        linkType == Ci.nsINetworkLinkService.LINK_TYPE_WIFI)) {
> +    status = false;
> +  }
> + 

nit: trailing whitespace

@@ +143,5 @@
>    let cacheSlow = data.cacheSlowCount;
>    let cacheNotSlow = data.cacheNotSlowCount;
>  
> +
> +

nit: whitespace
Attachment #8980220 - Flags: review?(valentin.gosu) → review+
Attachment #8980220 - Attachment is obsolete: true
Attachment #8980962 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4408bb821f5b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Is that something we want to add to the release notes?
Flags: needinfo?(michal.novotny)
Maybe we could. Release notes for 59 mentioned this feature, so we can now say that this is now also enabled on mobile when using wifi.
Flags: needinfo?(michal.novotny)
Duplicate of this bug: 1474017
Depends on: 1474275
Is there something we should be doing to verify this?
And, can you suggest wording for a release note for 62?
relnote-firefox: --- → ?
Flags: needinfo?(michal.novotny)
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #14)
> Is there something we should be doing to verify this?

You can verify that detecting WiFi works by looking at about:networking#rcwn where RCWN status should be true only when WiFi is used.

> And, can you suggest wording for a release note for 62?

Faster page load times on mobile when using WiFi by loading resources from the network if the disk cache is too slow.
Flags: needinfo?(michal.novotny)
Depends on: 1477593
Added to Firefox 62 release notes.
You need to log in before you can comment on or make changes to this bug.