Closed
Bug 1377579
Opened 7 years ago
Closed 7 years ago
Update GeckoView-based custom tabs to add progress bar back in
Categories
(Firefox for Android Graveyard :: General, enhancement)
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: droeh, Assigned: droeh)
Details
Attachments
(1 file)
6.21 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
We need to add progress bar support back in to custom tabs now that it's based on GeckoView. We should be able to do something similar to how Tab.java sets the load progress using just CustomTabsActivity.onPageStart() and CustomTabsActivity.onPageStop().
Assignee | ||
Comment 1•7 years ago
|
||
This more or less copies what we did in the GeckoApp-based implementation using Navigation/ProgressListener rather than Tab.getLoadProgress()
Assignee: nobody → droeh
Attachment #8885784 -
Flags: review?(snorp)
Attachment #8885784 -
Flags: review?(snorp) → review+
Pushed by droeh@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ad209e9d6fc1 Add progress bar to GeckoView-based custom tabs. r=snorp
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ad209e9d6fc1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•