Closed Bug 1377579 Opened 7 years ago Closed 7 years ago

Update GeckoView-based custom tabs to add progress bar back in

Categories

(Firefox for Android Graveyard :: General, enhancement)

53 Branch
All
Android
enhancement
Not set
normal

Tracking

(firefox56 fixed)

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: droeh, Assigned: droeh)

Details

Attachments

(1 file)

We need to add progress bar support back in to custom tabs now that it's based on GeckoView. We should be able to do something similar to how Tab.java sets the load progress using just CustomTabsActivity.onPageStart() and CustomTabsActivity.onPageStop().
This more or less copies what we did in the GeckoApp-based implementation using Navigation/ProgressListener rather than Tab.getLoadProgress()
Assignee: nobody → droeh
Attachment #8885784 - Flags: review?(snorp)
Attachment #8885784 - Flags: review?(snorp) → review+
Pushed by droeh@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad209e9d6fc1
Add progress bar to GeckoView-based custom tabs. r=snorp
https://hg.mozilla.org/mozilla-central/rev/ad209e9d6fc1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: