1377605 - mingw errors on signed vs unsigned comparison

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

> /home/worker/workspace/build/src/mozglue/misc/StackWalk.cpp:589:15: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
>    INFO -         if (ret == -1) {

Here ret is a DWORD, the result of SuspendThread(), whose error return is defined as `(DWORD) -1`.

Cast to DWORD to prevent the error.

Comment 1

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

Attachment: Bug 1377605 Cast -1 to DWORD to correctly match the error return value given by SuspendThread

Review commit: https://reviewboard.mozilla.org/r/153856/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153856/

Comment 2

[Tom Ritter [:tjr] (ni? for response to CVE/sec-approval/advisories/etc)]

Comment on attachment 8882746 [details]
Bug 1377605 Cast -1 to DWORD to correctly match the error return value given by SuspendThread

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153856/diff/1-2/

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8882746 [details]
Bug 1377605 Cast -1 to DWORD to correctly match the error return value given by SuspendThread

https://reviewboard.mozilla.org/r/153856/#review159936

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cc4de1e5897
Cast -1 to DWORD to correctly match the error return value given by SuspendThread r=aklotz

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4cc4de1e5897