Closed Bug 1377607 Opened 7 years ago Closed 7 years ago

HasStableTSC compares signed and unsigned and causes an error

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor])

Attachments

(1 file)

> /home/worker/workspace/build/src/mozglue/misc/TimeStamp_windows.cpp: In function 'bool mozilla::HasStableTSC()':
> /home/worker/workspace/build/src/mozglue/misc/TimeStamp_windows.cpp:481:15: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
>    if (regs[0] < 0x80000007) {
Attachment #8882761 - Flags: review?(nfroyd)
Comment on attachment 8882761 [details]
Bug 1377607 Cast int to unsigned to silence an error about signed vs unsigned comparisons

https://reviewboard.mozilla.org/r/153868/#review159178
Attachment #8882761 - Flags: review?(nfroyd) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2c9baffd57b
Cast int to unsigned to silence an error about signed vs unsigned comparisons r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c2c9baffd57b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: