Closed Bug 1377656 Opened 8 years ago Closed 8 years ago

BrowserElementParent.js, line 870: NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN: Cannot modify properties of a WrappedNative

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: peterv, Assigned: baku)

References

Details

Attachments

(1 file)

visibility.patch
3.02 KB, patch
kanru
: review+
Details | Diff | Splinter Review
Bug 1368712 removed nsIFrameLoader.visible, but _childVisibilityChange still tries to set it (see http://searchfox.org/mozilla-central/rev/dde5c480358718607cc40d752656c968a0e6eabd/dom/browser-element/BrowserElementParent.js#870). This makes us throw NS_ERROR_XPC_CANT_MODIFY_PROP_ON_WN.
Attached patch visibility.patch — — Splinter Review
Assignee: nobody → amarchesini
Attachment #8882824 - Flags: review?(kchen)
Attachment #8882824 - Flags: review?(kchen) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aa7d4f2c9697 Bug 1377656 - Remove visibility check in BrowserElement API, r=kanru
https://hg.mozilla.org/mozilla-central/rev/aa7d4f2c9697
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: