1377680 - stylo: Build AnimatedProperty only for servo

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d2265be7111c4c9eeaf1360879aba61368ce8e7

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1377680 - Don't use AnimatedProperty functions for gecko.

Review commit: https://reviewboard.mozilla.org/r/153900/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153900/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1377680 - Build AnimatedProperty and related functions only for servo.

Review commit: https://reviewboard.mozilla.org/r/153902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/153902/

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8882829 [details]
Bug 1377680 - Build AnimatedProperty and related functions only for servo.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/153902/diff/1-2/

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8882829 [details]
Bug 1377680 - Build AnimatedProperty and related functions only for servo.

https://reviewboard.mozilla.org/r/153902/#review159032

Removing the usage should be enough to avoid that code to be in the binary... Do we really need this?

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Oh, I did not know that. Then it's totally useless, cfg annotation for possibly_expired_animations will reduce memory usage (not binary size) but it's really small.

Comment 7

[Brian Birtles (:birtles)]

Comment on attachment 8882828 [details]
Bug 1377680 - Don't use AnimatedProperty functions for gecko.

https://reviewboard.mozilla.org/r/153900/#review159068

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Thank you!
https://github.com/servo/servo/pull/17592

Comment 9

[Hiroyuki Ikezoe (:hiro)]

https://hg.mozilla.org/mozilla-central/rev/2416b37516dc