1377716 - Forget panel cuts content

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[jlG]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170630030203

Steps to reproduce:

Nightly 56.0a1 (2017-06-30) (64-bit) es-ES, Windows 10
I customized the menu adding the FORGET option. After browsing for a while I pressed the "More tools..."  (Más herramientas...) and the Forget option.


Actual results:

The contents are not fully displayed, the button for forgetting is cut and only the top part is shown.

Screenshot: https://screenshots.firefox.com/R5k2aqivuElPwqla/null


Expected results:

I expect to see the whole button, as in previous versions of Firefox

Comment 1

[:Gijs (he/him)]

The patch in bug 1369729 should fix this. It's waiting on some work to automated tests.

Comment 2

[:Gijs (he/him)]

This works for me on today's nightly, which has the fix for bug 1369729. Can you confirm if this is fixed for you, too?

Comment 3

[jlG]

It's working for me too, I can see all the panel contents
Thanks!

Comment 4

[:Gijs (he/him)]

Thanks!

Paolo, technically this issue happens on 55 as well if you empty the hamburger panel out of most things, and do add the forget/panic button to it. This seems enough of an edgecase (moreso than with Photon where the panel starts out being empty) that I'm not convinced we need to fix it via uplift, but I'm wondering if there's other reasons to uplift the fix from bug 1369729 to 55 that I'm missing?

Comment 5

[:Paolo Amadini]

I'm not aware of other bugs the would affect the non-Photon version, on the other hand uplifting this change might mean that if we discover other issues later, they will be easier to uplift because the code is more similar between Beta and Nightly.