Open Bug 1377834 Opened 7 years ago Updated 2 years ago

ServoElementSnapshotFlags::Id and MaybeClass should really be separate bool variables

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- ?

People

(Reporter: heycam, Unassigned)

References

Details

Currently ServoElementSnapshotFlags has five values: State, Attributes, Id, MaybeClass and OtherPseudoClassState.  Of these, State, Attributes and OtherPseudoClassState reflect whether we've recorded the corresponding information on the snapshot object.  Id and MaybeClass are used differently though, and store whether the id="" and class="" values at the time all the attributes were added to the snapshot were present or not.  So I think they more properly belong as separate |bool ... : 1| fields on ServoElementSnapshot.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.