Open Bug 1377873 Opened 3 years ago Updated 1 year ago

Issues with videos when changing device orientation

Categories

(Firefox for Android :: Audio/Video, defect, P5)

56 Branch
ARM
Android
defect

Tracking

()

Tracking Status
fennec + ---
firefox56 --- affected
firefox64 --- affected
firefox65 --- affected

People

(Reporter: sflorean, Unassigned)

References

Details

(Keywords: stale-bug)

Attachments

(1 file)

Environment: 
Device: Asus ZenPad 8 (Android 6.0.1);
Build: Nightly 56.0a1 (2017-07-03);

Steps to reproduce:
1. Launch Fennec and open a video from www.nytimes.com; 
2. Put the video in full mode;
3. Change device orientation from portrait to landscape;

Expected result:
The video keeps playing and no interruptions or glitches are triggered.

Actual result:
When device orientation is changed the video has a white area. 

Notes:
See the video: https://drive.google.com/open?id=0B0Rtl9OVJNMCUmFMN0l6aFQyTDQ
Sorina,
I think this issue should happen on non-HLS content as well. Can you check if you can see this problem on Youtube or not?
Flags: needinfo?(sorina.florean)
I can see but it's more obvious on HLS video, it remains stuck for 2-3 seconds while on Youtube it's a glitch. 
 I will change the name of bug. Will be fixed for HLS as well?
tracking-fennec: --- → ?
Flags: needinfo?(sorina.florean)
Summary: [Fennec][HLS] Issues when changing device orientation → Issues with videos when changing device orientation
Hi Sorina,

Thanks for reporting this issue and I can also reproduce it easily by playing Youtube video with white area appeared when changing orientation.

Would you please share the tool you record the device? It seems handy and the quality is great.


Thanks.
Flags: needinfo?(sorina.florean)
Xindorn,
jhlin mentioned offline that it could be a full screen layout problem. 
Can you help us check it?
Flags: needinfo?(xidorn+moz)
(In reply to Blake Wu [:bwu][:blakewu] from comment #4)
> Xindorn,
Sorry. I typed too fast.. Xidorn! :-)
I can reproduce this.

The white area's appearing temporarily after device orientation change doesn't seem to be something specific to fullscreen. It happens whenever the page takes long to render. It is more obvious in fullscreen because the area is white while background in fullscreen is black.

You can see the attached testcase, which is an example of page which is expensive to reflow after device orientation change.

So then the question is, does it render particularly slow when in fullscreen, or it always renders that slow, just more obvious with fullscreen? If it is only slow in fullscreen, there might be some bug with fullscreen, otherwise it should just be a general performance issue in layout. Either way, it would be helpful if there could be some profiling.

Another question is, can we improve user experience in this case even if we cannot make it faster? That says, can we block the orientation change on the user interface until rendering finishes, so that user would not see any glitch after orientation changes? That would probably be a question for Fennec frontend developer.
Flags: needinfo?(xidorn+moz)
(In reply to James Cheng[:JamesCheng] from comment #3)
> Hi Sorina,
> 
> Thanks for reporting this issue and I can also reproduce it easily by
> playing Youtube video with white area appeared when changing orientation.
> 
> Would you please share the tool you record the device? It seems handy and
> the quality is great.
> 
> 
> Thanks.

Hi, James
After I connect my device to PC I use this command [1] and the video is saved on device. And CTRL+C to stop recording.
[1] adb shell screenrecord /sdcard/record7.mp4
Flags: needinfo?(sorina.florean)
We should fix bug 842782 and see if we still see this problem.
Depends on: 842782
[triage@0712] +, Media team is tracking it.
tracking-fennec: ? → +
I can see this problem when playing CNN News video which doesn't use HLS, so this is a common problem, not specific on HLS.
No longer blocks: HLS_on_Fennec
Priority: -- → P1
Note that Chrome locks to landscape when in fullscreen.
(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #11)
> Note that Chrome locks to landscape when in fullscreen.
Yeah. That's what we would like to fix in bug 842782.
This is a P1 bug without an assignee. 

P1 are bugs which are being worked on for the current release cycle/iteration/sprint. 

If the bug is not assigned by Monday, 28 August, the bug's priority will be reset to '--'.
Keywords: stale-bug
Mass change P1->P2 to align with new Mozilla triage process.
Priority: P1 → P2
Duplicate of this bug: 1362135
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
Priority: P2 → P5
Botond, do you have any thoughts on this in relation to Bug 1509552 and 1510029?
Flags: needinfo?(botond)
See comment 6, this is because of slow reflow which causes intermediate state to be rendered.
I agree with Xidorn. There is no relation to bug 1509552 or bug 1511029.

This is a temporary artifact of orientation changes which is fairly normal. I would almost consider it "wontfix", except for solutions like comment 12 (locking the orientation to landscape in fullscreen mode) which sidesteps the issue.
Flags: needinfo?(botond)
You need to log in before you can comment on or make changes to this bug.