1377894 - WARN:webrender::scene: Property binding PropertyBindingKey { id: PropertyBindingId { namespace: 2989, uid: 1234 }, _phantom: PhantomData } has an invalid value.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

Seen this getting spammed in a bunch of intermittent failure logs:

WARN:webrender::scene: Property binding PropertyBindingKey { id: PropertyBindingId { namespace: 2989, uid: 1234 }, _phantom: PhantomData } has an invalid value.

https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=110316321&lineNumber=39747
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=110740104&lineNumber=40599

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Still seeing this as of August 10 even on passing runs.

Comment 2

[Peter Chang[:pchang]]

I also saw these log with debug build recently. I will work on this.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Did you make any progress on this? I suspect this output is contributing to talos failures because the logs overflow. So fixing it would be quite useful.

Comment 4

[Peter Chang[:pchang]]

I saw two different kinds of warning logs in the following.
For the 'zero' id one, we could filter it by checking valid animation id in [1].
It could reduce lots of warning.

For the non-zero id cases, I guest compositor reject the animations request but we still push this animation request on the content side.

[Logs]
WARN:webrender::scene: Property binding PropertyBindingId { namespace: IdNamespace(0), uid: 0 } has an invalid value about opacity. value 1
WARN:webrender::scene: Property binding PropertyBindingId { namespace: IdNamespace(51489), uid: 1 } has an invalid value about opacity. value 1

[1]http://searchfox.org/mozilla-central/rev/298033405057ca7aa5099153797467eceeaa08b5/gfx/webrender_bindings/src/bindings.rs#1175

Comment 5

[Kartikaya Gupta (email:[e-mail])]

(In reply to Peter Chang[:pchang] from comment #4)
> I saw two different kinds of warning logs in the following.
> For the 'zero' id one, we could filter it by checking valid animation id in
> [1].
> It could reduce lots of warning.

This makes sense, and would help a lot. Are you going to write a patch for this, or do you want me to?

Comment 6

[Peter Chang[:pchang]]

I just submit a try to see we can pass talos or not with layers-free enabled.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3610ecf157ef531ec9487416fd345df75e44ae58

Comment 7

[Peter Chang[:pchang]]

Attachment: Bug 1377894 - Create the new opacity animations only when the animation id is valid,

Review commit: https://reviewboard.mozilla.org/r/185598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/185598/

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8914311 [details]
Bug 1377894 - Create the new opacity animations only when the animation id is valid,

https://reviewboard.mozilla.org/r/185598/#review190572

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Looks like it didn't help with the talos :/ Still worth landing though. If we can get to the bottom of the other source of the output that would be good as well.

Comment 10

[Peter Chang[:pchang]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #8)
> Comment on attachment 8914311 [details]
> Bug 1377894 - Create the new opacity animations only when the animation id
> is valid,
> 
> https://reviewboard.mozilla.org/r/185598/#review190572

This one only fixed the warning log with zero id, I will keep working on the non-zero id.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7a2d0f49c4c
Create the new opacity animations only when the animation id is valid, r=kats

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b7a2d0f49c4c

Comment 13

[Peter Chang[:pchang]]

I just found the cause for the warning log with non-zero id but I had problem to sumbit the patch via mozreview. So I will clone this bug for the follow-up work.

Comment 14

[Peter Chang[:pchang]]

I shouldn't change the title.

Comment 15

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.