1377897 - Crash in mozilla::net::nsHttpConnectionMgr::nsHalfOpenSocket::StartFastOpen

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-0e96d107-0ef0-42f1-81db-23ad40170701.
=============================================================

Seen while looking at crash stats from 20170701030203: http://bit.ly/2tETmpv

ni on Dragana since this was in the window when we turned on TCP Fast Open (I think...)

Comment 1

[Dragana Damjanovic [:dragana]]

This should be fixed. I am running a test in the next Nightly and I will verify the fix.
Keeping needinfo to check it in next days.

Comment 2

[Dragana Damjanovic [:dragana]]

I wanted to test a fix for this in a tfo test run, but it was backed out. So I will make patch, and test it in the next test.

Comment 3

[Dragana Damjanovic [:dragana]]

Attachment: bug_1377897.patch

Comment 4

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cfaa3783678b5a6a318c7fb8b91c65820e30c3f

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04a63574fd9b
If a HalfOpen can be Abndoned we need to check if mEnt is still present before setting mDoNotDestroy. r=mcmanus

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/04a63574fd9b