Assertion failure: aFrame->HasImageRequest() when printing nytimes.com

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Alex_Gaynor, Assigned: mats)

Tracking

({assertion, regression})

55 Branch
mozilla56
assertion, regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox54 unaffected, firefox55 wontfix, firefox56 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
STR:

1) Use latest central (a3b192dc8344)
2) Browse to https://www.nytimes.com/
3) Cmd-p to print up print dialog
4) Click on "PDF" dropdown
5) Select "Open PDF in Preview"
6) Crash

Here's the stacktrace:

Assertion failure: aFrame->HasImageRequest() (why call me?), at /Users/agaynor/projects/mozilla-central/layout/style/ImageLoader.cpp:183
#01: AddAndRemoveImageAssociations(nsFrame*, nsStyleImageLayers const*, nsStyleImageLayers const*)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x31aa643]
#02: nsFrame::DidSetStyleContext(nsStyleContext*)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x318577d]
#03: nsIFrame::SetStyleContext(nsStyleContext*)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x30658a6]
#04: mozilla::ElementRestyler::RestyleSelf(nsIFrame*, nsRestyleHint, unsigned int*, nsTArray<mozilla::ElementRestyler::SwapInstruction>&)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306b453]
#05: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068650]
#06: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#07: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#08: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#09: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#10: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#11: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#12: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#13: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#14: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#15: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#16: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#17: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#18: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#19: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#20: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#21: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#22: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#23: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#24: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#25: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#26: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#27: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#28: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#29: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#30: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#31: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#32: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#33: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#34: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#35: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#36: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#37: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#38: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#39: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#40: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#41: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#42: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#43: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#44: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#45: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#46: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#47: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#48: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#49: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#50: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#51: mozilla::ElementRestyler::RestyleContentChildren(nsIFrame*, nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306fef6]
#52: mozilla::ElementRestyler::RestyleChildren(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306de9e]
#53: mozilla::ElementRestyler::Restyle(nsRestyleHint)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3068c89]
#54: mozilla::ElementRestyler::ComputeStyleChangeFor(nsIFrame*, nsStyleChangeList*, nsChangeHint, mozilla::RestyleTracker&, nsRestyleHint, mozilla::RestyleHintData const&, nsTArray<mozilla::ElementRestyler::ContextToClear>&, nsTArray<RefPtr<nsStyleContext> >&)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3070a6f]
#55: mozilla::GeckoRestyleManager::ComputeAndProcessStyleChange(nsIFrame*, nsChangeHint, mozilla::RestyleTracker&, nsRestyleHint, mozilla::RestyleHintData const&)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3062832]
#56: mozilla::GeckoRestyleManager::StartRebuildAllStyleData(mozilla::RestyleTracker&)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x30625f3]
#57: mozilla::RestyleTracker::DoProcessRestyles()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x30a12b7]
#58: mozilla::GeckoRestyleManager::ProcessPendingRestyles()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x306413c]
#59: mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3086f01]
#60: nsHideViewer::Run()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3278c9d]
#61: nsContentUtils::RemoveScriptBlocker()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x127e8da]
#62: mozilla::PresShell::ReconstructFrames()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3089866]
#63: nsPrintEngine::ReconstructAndReflow(bool)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x34801cd]
#64: nsPrintEngine::SetupToPrintContent()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x347f210]
#65: nsPrintEngine::DocumentReadyForPrinting()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x347ef9e]
#66: nsPrintEngine::AfterNetworkPrint(bool)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3481e35]
#67: nsPrintEngine::InitPrintDocConstruction(bool)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x347d283]
#68: nsPrintEngine::Observe(nsISupports*, char const*, char16_t const*)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x3484674]
#69: mozilla::embedding::PrintProgressDialogChild::RecvDialogOpened()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x45c2149]
#70: mozilla::embedding::PPrintProgressDialogChild::OnMessageReceived(IPC::Message const&)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x8be8e7]
#71: mozilla::dom::PContentChild::OnMessageReceived(IPC::Message const&)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0xac8b4e]
#72: mozilla::ipc::MessageChannel::DispatchAsyncMessage(IPC::Message const&)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x6e9de9]
#73: mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x6e7c05]
#74: mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x6e8b65]
#75: mozilla::ipc::MessageChannel::MessageTask::Run()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x6e937a]
#76: mozilla::SchedulerGroup::Runnable::Run()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x1169e5]
#77: nsThread::ProcessNextEvent(bool, bool*)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x12f35a]
#78: NS_ProcessPendingEvents(nsIThread*, unsigned int)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x12c0cc]
#79: nsBaseAppShell::NativeEventCallback()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2d10a81]
#80: nsAppShell::ProcessGeckoEvents(void*)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2d7d795]
#81: __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__[/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0xa7321]
#82: __CFRunLoopDoSources0[/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x8821d]
#83: __CFRunLoopRun[/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x87716]
#84: CFRunLoopRunSpecific[/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation +0x87114]
#85: RunCurrentEventLoopInMode[/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox +0x30ebc]
#86: ReceiveNextEventCommon[/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox +0x30cf1]
#87: _BlockUntilNextEventMatchingListInModeWithFilter[/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox +0x30b26]
#88: _DPSNextEvent[/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x46a54]
#89: -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:][/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x7c27ee]
#90: -[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:][/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2d7cb14]
#91: -[NSApplication run][/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit +0x3b3db]
#92: nsAppShell::Run()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x2d7dec3]
#93: XRE_RunAppShell()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x45ec7e8]
#94: mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x6ee097]
#95: MessageLoop::Run()[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x69e1aa]
#96: XRE_InitChildProcess(int, char**, XREChildData const*)[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x45ec475]
#97: main[/Users/agaynor/projects/mozilla-central/obj-x86_64-apple-darwin16.6.0/dist/NightlyDebug.app/Contents/MacOS/plugin-container.app/Contents/MacOS/plugin-container +0xec7]
(Assignee)

Comment 1

a year ago
Regression from bug 1367207 I presume, which added this assertion.
Should be harmless in non-DEBUG builds - the assertion is merely
pointing out that the caller can be optimized to avoid this
expensive call.
Assignee: nobody → mats
Blocks: 1367207
Keywords: assertion, regression
OS: Mac OS X → All
Hardware: Unspecified → All
(Assignee)

Comment 3

a year ago
Created attachment 8883667 [details] [diff] [review]
fix
Attachment #8883667 - Flags: review?(dholbert)
Comment on attachment 8883667 [details] [diff] [review]
fix

Review of attachment 8883667 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8883667 - Flags: review?(dholbert) → review+

Comment 5

a year ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45ca2566d2bf
Don't bother calling DisassociateRequestFromFrame if the frame doesn't have the HasImageRequest bit since it's a no-op in that case.  r=dholbert

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/45ca2566d2bf
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Is this worth backporting to Beta or should we let it ride the 56 train?
status-firefox54: --- → unaffected
status-firefox55: --- → affected
status-firefox-esr52: --- → unaffected
Flags: needinfo?(dholbert)
Version: Trunk → 55 Branch
Doesn't sound like it's worth a beta backport, per comment 1. This is basically a small optimization - let's let it ride the trains.
Flags: needinfo?(dholbert)
status-firefox55: affected → wontfix
You need to log in before you can comment on or make changes to this bug.