Closed Bug 1377913 Opened 7 years ago Closed 7 years ago

The first item in the fixed-overflow panel has too much margin-top

Categories

(Firefox :: Theme, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1354086

People

(Reporter: jaws, Unassigned)

Details

Attachments

(1 file)

The first item in the fixed-overflow panel has too much margin-top. We should only be setting margin-top for items that are not the first-child. This rule here is the cause of the problem, http://searchfox.org/mozilla-central/rev/5bb6dfcb3355a912c20383578bc435c1d4ecf575/browser/themes/shared/customizableui/panelUI.inc.css#1382

It is currently matching on the first selector, `panelview .toolbarbutton-1`.
Blocks: 1352692
No longer blocks: photon-structure
Depends on: 1354086
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Whiteboard: [photon-structure][triage]
Eh, meant to comment here when duping, but for completeness' sake: I duped this because ultimately, for the photon styling we want to get rid of the margin completely, and so updating the selector only to exclude the top item isn't really that useful, and it seems to me verifying the new styling will also verify this bug, so keeping a separate bug open doesn't seem worth it.
No longer blocks: 1352692
No longer depends on: 1354086
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: